Skip to content

fix metadata to mark KEP-5307 implementable #5421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 19, 2025
Merged

fix metadata to mark KEP-5307 implementable #5421

merged 1 commit into from
Jun 19, 2025
+2 −2

Conversation

SergeyKanzhelev
Copy link
Member

/sig node

@k8s-ci-robot k8s-ci-robot added sig/node Categorizes an issue or PR as relevant to SIG Node. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory labels Jun 18, 2025
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 18, 2025
mrunalp
mrunalp approved these changes Jun 18, 2025
View reviewed changes
Copy link
Contributor

@mrunalp mrunalp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jun 18, 2025
@k8s-ci-robot k8s-ci-robot removed lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jun 18, 2025
@SergeyKanzhelev SergeyKanzhelev mentioned this pull request Jun 18, 2025
Open
5 tasks
BenTheElder
BenTheElder reviewed Jun 18, 2025
View reviewed changes
keps/prod-readiness/sig-node/5307.yaml
@@ -1,3 +1,3 @@
kep-number: 5307
alpha:
approver: " wojtek-t"
approver: "wojtek-t"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

... we should probably add validation to this.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, I am fixing this as pull-enhancements-test fails otherwise: https://prow.k8s.io/pr-history/?org=kubernetes&repo=enhancements&pr=5421

this contributor ( wojtek-t) is not a PRR approver ([deads2k ehashman johnbelamaric jpbetz soltysh wojtek-t])"

But somehow the original PR that added it didn't fail this test

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huh, that was #5308 ? which passed in https://prow.k8s.io/view/gs/kubernetes-ci-logs/pr-logs/pull/enhancements/5308/pull-enhancements-test/1935391268074950656

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes. Not sure why as I am sure the check on whether PRR review is needed seems to be running on PRs (I am pretty sure, didn't validate recently)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Filed a bug: #5422

Copy link
Member

@wojtek-t wojtek-t Jun 19, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The validating is done only for implementable KEPs - so that you can merge provisional KEP without PRR.
This is WAI.

@SergeyKanzhelev
Copy link
Member Author

@deads2k can you please merge this as @wojtek-t is likely asleep by now =)

@SergeyKanzhelev SergeyKanzhelev mentioned this pull request Jun 18, 2025
Open
@wojtek-t
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 19, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mrunalp, SergeyKanzhelev, wojtek-t

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 19, 2025
@k8s-ci-robot k8s-ci-robot merged commit 23b5dff into kubernetes:master Jun 19, 2025
4 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.34 milestone Jun 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BenTheElder BenTheElder BenTheElder left review comments

@wojtek-t wojtek-t wojtek-t left review comments

@mrunalp mrunalp mrunalp approved these changes

@dchen1107 dchen1107 Awaiting requested review from dchen1107

Assignees

@mrunalp mrunalp

@wojtek-t wojtek-t

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/node Categorizes an issue or PR as relevant to SIG Node. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.34
Development

Successfully merging this pull request may close these issues.
5 participants
@SergeyKanzhelev @wojtek-t @k8s-ci-robot @mrunalp @BenTheElder