Skip to content

KEP-4381: Add pciBusID standard device attribute definition #5669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+14 −4
Open

KEP-4381: Add pciBusID standard device attribute definition #5669

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 14 additions & 4 deletions keps/sig-node/4381-dra-structured-parameters/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -492,12 +492,15 @@ Compared to labels, attributes have values of exactly one type. Quantities are d
in the separate `capacity` map. As described later on, both sets can be used in CEL expressions to select a
specific resource for allocation on a node.

We are reserving the `kubernetes.io/` domain (and subdomains) prefix for
We propose reserving the `kubernetes.io/` domain (and subdomains) prefix for
attributes and capacities for standardization by the Kubernetes project. This
reservation allows us to define common attributes that can describe hardware
characteristics across resources from different vendors. Currently, we are
defining one such standard attribute: `resource.kubernetes.io/pcieRoot`. Details
on its meaning and how it should be exposed by DRA drivers are available in the
characteristics across resources from different vendors. This KEP proposes that we maintain
a number of such standard attributes:
1. `resource.kubernetes.io/pcieRoot`
2. `resource.kubernetes.io/pciBusID`

Details on their meaning and how they should be exposed by DRA drivers are available in the
[API design section under ResourceSlice's](#resourceslice) QualifiedName
definition.

Expand Down Expand Up @@ -1127,6 +1130,13 @@ const ResourceSliceMaxAttributesAndCapacitiesPerDevice = 32
// entry in sysfs (e.g., `/sys/devices/pci0000:00/0000:00:01.0/0000:01:00.0`),
// where the `pci<domain>:<bus>` segment at the beginning of the real path
// identifies the Root Complex (e.g., `pci0000:00`).
// 2. `resource.kubernetes.io/pciBusID`: A string value in the format
// `<socket>:<bus>:<domain>.<function>`, referring to a PCI (Perpheral Component
// Interconnect) Bus Address. This attribute can be used to identify PCI devices.
// DRA drivers MAY determine this value by inspecting the device's entry in sysfs
// (e.g., `/sys/bus/pci/devices/0000:00:01.0`) where the
// `<socket>:<bus>:<domain>.<function>` segment at the end identifies the PCI
// Bus Address (e.g., `0000:00:01.0`)
//
// The maximum length for the DNS subdomain is 63 characters (same as
// for driver names) and the maximum length of the C identifier
Expand Down