Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update NEG reference in NEG CR #2604

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Update NEG reference in NEG CR #2604

wants to merge 2 commits into from
+370 −43

Conversation

sawsa307
Copy link
Contributor

  • Populate Subnet in NEG CR based on the subnet on the NEG.
  • Populate State as ACTIVE for newly created NEGs. For NEGs in the zones which don't have any nodes, set their state as INACTIVE.
  • Remove deleted NEG reference during NEG GC.

/assign @swetharepakula

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 17, 2024
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 17, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sawsa307
Once this PR has been reviewed and has the lgtm label, please ask for approval from swetharepakula. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 19, 2024
@sawsa307 sawsa307 force-pushed the update-neg-ref branch 9 times, most recently from 8449144 to eefaff0 Compare July 24, 2024 21:21
swetharepakula
swetharepakula reviewed Jul 25, 2024
View reviewed changes
pkg/neg/syncers/transaction.go Outdated Show resolved Hide resolved
pkg/neg/syncers/transaction.go Outdated Show resolved Hide resolved
pkg/neg/syncers/transaction.go Outdated Show resolved Hide resolved
pkg/neg/syncers/transaction_test.go Show resolved Hide resolved
pkg/neg/syncers/transaction_test.go Show resolved Hide resolved
pkg/neg/manager.go Outdated Show resolved Hide resolved
pkg/neg/manager.go Outdated Show resolved Hide resolved
sawsa307
sawsa307 commented Jul 25, 2024
View reviewed changes
Copy link
Contributor Author

@sawsa307 sawsa307 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed all the comments, PTAL!

pkg/neg/syncers/transaction.go Outdated Show resolved Hide resolved
pkg/neg/syncers/transaction_test.go Show resolved Hide resolved
pkg/neg/syncers/transaction_test.go Show resolved Hide resolved
pkg/neg/syncers/transaction.go Outdated Show resolved Hide resolved
pkg/neg/syncers/transaction.go Outdated Show resolved Hide resolved
pkg/neg/manager.go Outdated Show resolved Hide resolved
pkg/neg/manager.go Outdated Show resolved Hide resolved
@sawsa307 sawsa307 force-pushed the update-neg-ref branch 6 times, most recently from 84e33cd to f343cbb Compare July 26, 2024 06:30
@sawsa307 sawsa307 force-pushed the update-neg-ref branch 2 times, most recently from f6fa060 to 01cdea5 Compare August 2, 2024 23:21
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 2, 2024
@sawsa307 sawsa307 force-pushed the update-neg-ref branch 2 times, most recently from ba9f4e8 to 0de216d Compare August 28, 2024 22:31
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 12, 2024
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Sep 16, 2024
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 17, 2024
@sawsa307 sawsa307 mentioned this pull request Sep 17, 2024
Merged
swetharepakula
swetharepakula reviewed Sep 17, 2024
View reviewed changes
pkg/neg/syncers/transaction_test.go Outdated Show resolved Hide resolved
pkg/neg/syncers/transaction_test.go Outdated Show resolved Hide resolved
pkg/neg/syncers/transaction_test.go Outdated Show resolved Hide resolved
pkg/neg/syncers/transaction_test.go Outdated Show resolved Hide resolved
pkg/neg/syncers/transaction_test.go Outdated Show resolved Hide resolved
pkg/neg/syncers/transaction_test.go Outdated Show resolved Hide resolved
sawsa307
sawsa307 commented Sep 18, 2024
View reviewed changes
Copy link
Contributor Author

@sawsa307 sawsa307 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated, please take a look! @swetharepakula

pkg/neg/syncers/transaction_test.go Outdated Show resolved Hide resolved
pkg/neg/syncers/transaction_test.go Outdated Show resolved Hide resolved
pkg/neg/syncers/transaction_test.go Outdated Show resolved Hide resolved
pkg/neg/syncers/transaction_test.go Outdated Show resolved Hide resolved
pkg/neg/syncers/transaction_test.go Outdated Show resolved Hide resolved
@sawsa307 sawsa307 force-pushed the update-neg-ref branch 3 times, most recently from 3ddd5ea to c630d45 Compare September 18, 2024 18:10
@sawsa307
Populate State and Subnet for NEG reference in NEG CR.
11360e1 
* Populate Subnet in NEG CR based on the subnet on the NEG.
* Populate State as ACTIVE for new and existing NEGs. For NEGs in the zones
  which don't have any nodes, set their state as INACTIVE.
@sawsa307
Remove deleted NEG reference during NEG GC.
581ba4d 
* Once a NEG has been deleted, remove its referece from NEG CR. This
  prevents NEG CR retaining reference of non-existing NEGs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aojea aojea Awaiting requested review from aojea

@gauravkghildiyal gauravkghildiyal Awaiting requested review from gauravkghildiyal

@swetharepakula swetharepakula Awaiting requested review from swetharepakula

Assignees

@swetharepakula swetharepakula

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sawsa307 @k8s-ci-robot @swetharepakula