Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip adding NEGs in to-be-deleted state when querying from Svcneg. #2619

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Skip adding NEGs in to-be-deleted state when querying from Svcneg. #2619

wants to merge 1 commit into from
+15 −0

Conversation

sawsa307
Copy link
Contributor

@sawsa307 sawsa307 commented Aug 6, 2024

  • Backend Service updates are performed by providing a new list of backends every time. Thus, if we skip adding NEGs in to-be-delated state, they will be detached from Backend Services when a sync triggers.
  • Currently, in fail-safe situation we get NEGs by querying GCE. Once CRD is ready, we will make sure to get the subnet information and also include NEGs from non-default subnet.

/assign @swetharepakula

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Aug 6, 2024
@sawsa307 sawsa307 changed the title Skip adding NEGs in non-default subnet when querying from Svcneg. Skip adding NEGs in to-be-deleted state when querying from Svcneg. Aug 6, 2024
@sawsa307
Copy link
Contributor Author

/retest

@sawsa307 sawsa307 force-pushed the remove-tbd-neg branch 2 times, most recently from 9fe8dbc to 023a6f0 Compare September 16, 2024 20:23
@gauravkghildiyal
Copy link
Member

/assign

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 17, 2024
@sawsa307
Skip adding NEGs in to-be-deleted state when querying from Svcneg.
363bc49 
* Backend Service updates are performed by providing a new list of
  backends every time. Thus, if we skip adding NEGs in to-be-delated
  state, they will be detached from Backend Services when a sync
  triggers.
* Currently, in fail-safe situation we get NEGs by querying GCE. Once
  CRD is ready, we will make sure to get the subnet information and also
  include NEGs from non-default subnet.
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sawsa307
Once this PR has been reviewed and has the lgtm label, please ask for approval from gauravkghildiyal. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aojea aojea Awaiting requested review from aojea

@gauravkghildiyal gauravkghildiyal Awaiting requested review from gauravkghildiyal

Assignees

@swetharepakula swetharepakula

@gauravkghildiyal gauravkghildiyal

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sawsa307 @gauravkghildiyal @k8s-ci-robot @swetharepakula