-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: update dashboard to support namespace selection #11932
base: main
Are you sure you want to change the base?
Conversation
change will alter "Service Ingress" variable to "Ingress Namespace" and "Ingress". This better alligns with the variable selection found in the controller dashboard (nginx.json)
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: toredash The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This issue is currently awaiting triage. If Ingress contributors determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Hi @toredash. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
✅ Deploy Preview for kubernetes-ingress-nginx canceled.
|
This is stale, but we won't close it automatically, just bare in mind the maintainers may be busy with other tasks and will reach your issue ASAP. If you have any question or request to prioritize this, please reach |
The This bot removes
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /remove-lifecycle frozen |
Update to the request handling performance dashboard.
What this PR does / why we need it:
If multiple Ingress objects share the same name between namespaces, there is no way to select the correct Ingress. This change will allow for selecting the namespace as well.
This change will more closely match the current variable selection found in the existing controller dashboard
Types of changes
Which issue/s this PR fixes
N/A
How Has This Been Tested?
As this is a visual change, I've tested this in two environment to be able to showcase the difference:
Checklist: