-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NGINX: Migrate server redirects to NJS. #12448
base: main
Are you sure you want to change the base?
NGINX: Migrate server redirects to NJS. #12448
Conversation
Signed-off-by: Anurag Rajawat <[email protected]>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: elizabeth-dev The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This issue is currently awaiting triage. If Ingress contributors determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Hi @elizabeth-dev. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
✅ Deploy Preview for kubernetes-ingress-nginx ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
What this PR does / why we need it:
Migrate the Lua scripting code for calculating server redirect targets to NJS, maintaining the same behavior.
Depends on #12345 (change starts from that branch)
Types of changes
Which issue/s this PR fixes
Part of #12383
How Has This Been Tested?
The new implementation has been tested manually to verify that the redirect it produces matches the one in Lua, as well as passing the e2e test suite
Checklist: