-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(customheaders): add test for annotation added #12479
base: main
Are you sure you want to change the base?
Conversation
The committers listed above are authorized under a signed CLA. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: qvalentin The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Welcome @qvalentin! |
Hi @qvalentin. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
✅ Deploy Preview for kubernetes-ingress-nginx canceled.
|
a398fe5
to
1d3b302
Compare
/kind bug |
What this PR does / why we need it:
Types of changes
Which issue/s this PR fixes
fixes #11680.
reproduces the issue with a e2e test.
Based on #11709. I just added the e2e test.
How Has This Been Tested?
The existing e2e did only test the customheaders annotation on an newly created ingress.
This pr adds a second e2e tests that tests what happens, when the annotation is added to an existing ingress.
Checklist: