Controller: Fix SSL session ticket path.

[VojtechBuba]

What this PR does / why we need it:

Fix path for storing ssl session tickets key. Docker container does not have permission to write to /etc/ingress-controller because it is owned by root.

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• CVE Report (Scanner found CVE and adding report)
• Breaking change (fix or feature that would cause existing functionality to change)
• Documentation only

Which issue/s this PR fixes

#13635

How Has This Been Tested?

I'm not able to test that, i just try to speed up the process.

Checklist:

• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I've read the CONTRIBUTION guide
• I have added unit and/or e2e tests to cover my changes.
• All new and existing tests passed.

[linux-foundation-easycla]

• ✅login: VojtechBuba / (78f59f2)
• ✅login: VojtechBuba / (78f59f2, 5b17458)

The committers listed above are authorized under a signed CLA.

[netlify]

✅ Deploy Preview for kubernetes-ingress-nginx canceled.

Name	Link
🔨 Latest commit	4e1b438
🔍 Latest deploy log	https://app.netlify.com/projects/kubernetes-ingress-nginx/deploys/6880a69ce17afb0008fc5f6a

[k8s-ci-robot]

Welcome @VojtechBuba!

It looks like this is your first PR to kubernetes/ingress-nginx 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/ingress-nginx has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @VojtechBuba. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[Gacko]

Please also implement a test, so we are not hitting this issue again in the future. Thank you!

[Gacko]

/retitle Controller: Fix SSL session ticket path.
/triage accepted
/kind bug
/priority backlog
/hold

[VojtechBuba]

@Gacko I'm sorry, but i am not able to do that, because i`m not a Go programmer. I hope, that we can somehow figure this out.

[Gacko]

I'm afraid of just merging this, even though it looks like a simple fix, because we already had more than enough complaints regarding simple looking, but untested changes in the past.

[Gacko]

I'm going to test this as soon as I got some time.

[VojtechBuba]

@Gacko Thank you very much

[Gacko]

In the same PR @rikatz back then changed the permissions for the /etc/ingress-controller directory and moved stuff from /etc/nginx there, he also added a document about the files we need and where to place them:

https://github.com/rikatz/ingress-nginx/blob/main/docs/enhancements/20231001-split-containers.md

This document states /etc/ingress-controller/tickets.key to be fine and since he did not remove /etc/ingress-controllers from the write directories in the Dockerfile of the chroot variant of the controller, I'd assume it to be fine to just revert this particular change by adding it back to the normal variant of the controller here.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: VojtechBuba

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[Gacko]

This was not intended, sorry. Fixing...

[Gacko]

Ok, here is the thing: I tried to implement the change I asked for on your fork (there's a checkbox to grant write access to your PR branch on PR creation and you checked it), but messed up Git and then GitHub just closed the PR and now I can no longer fix this on your branch because the PR got closed and so the permissions got revoked.

Anyway, I'm gonna come up with a new PR and mention you in the commit message.