Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ensure prow-build can operate secret manager secrets #7416

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

ensure prow-build can operate secret manager secrets #7416

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
704d999
ensure prow-build can operate secret manager secrets
dargudear-google Oct 16, 2024
8674056
Update infra/gcp/bash/prow/ensure-e2e-projects.sh
dargudear-google Oct 25, 2024
38840a3
Remove duplicate entry for secretmanager
dargudear-google Oct 25, 2024
4da328b
Remove permission for compute service account.
dargudear-google Oct 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions infra/gcp/bash/prow/ensure-e2e-projects.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,7 @@ function ensure_e2e_project() {
file.googleapis.com \
logging.googleapis.com \
monitoring.googleapis.com \
secretmanager.googleapis.com \
storage-component.googleapis.com

# TODO: this is what prow.k8s.io uses today, but seems overprivileged, we
Expand Down Expand Up @@ -112,6 +113,11 @@ function ensure_e2e_project() {
"serviceAccount:${PROW_BUILD_SVCACCT}" \
"roles/iam.serviceAccountUser"

# Ensure GCP Default Compute Service Account can administer Secret Manager secrets
ensure_project_role_binding "${prj}" \
"serviceAccount:${PROW_BUILD_SVCACCT}" \
"roles/secretmanager.admin"

# TODO: this is what prow.k8s.io uses today, but seems overprivileged, we
# could consider using a more limited custom IAM role instead
color 6 "Empower boskos-janitor service account to clean e2e project: ${prj}"
Expand Down