Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Azure: update tag for resource group post cluster creation #7499

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ameukam
Copy link
Member

@ameukam ameukam commented Nov 7, 2024

Follow-up of:

https://github.com/Azure/rg-cleanup/ is deployed at
the subscription level to delete resource groups older than 3 days to
clean resources left post prowjobs execution. This is also affect the resource
groups auto-created by AKS clusters.
rg-cleanup will not clean up resource groups with specific tags
(e.g.DO-NOT-DELETE)
Tag is added to ensure rg-cleanup do remove the resource groups of the
build cluster.

Signed-off-by: Arnaud Meukam [email protected]

Follow-up of:
  - kubernetes#7472

https://github.com/Azure/rg-cleanup/ is deployed at
the subscription level to delete resource groups older than 3 days to
clean resources left post prowjobs execution. This is also affect the resource
groups auto-created by AKS clusters.
`rg-cleanup` will not clean up resource groups with specific tags
(e.g.`DO-NOT-DELETE`)
Tag is added to ensure `rg-cleanup` do remove the resource groups of the
build cluster.

Signed-off-by: Arnaud Meukam <[email protected]>
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 7, 2024
@ameukam
Copy link
Member Author

ameukam commented Nov 7, 2024

cc @dims @BenTheElder @upodroid

@k8s-ci-robot k8s-ci-robot added the area/infra Infrastructure management, infrastructure design, code in infra/ label Nov 7, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ameukam

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added area/infra/azure Issues or PRs related to Kubernetes Azure infrastructure approved Indicates a PR has been approved by an approver from all required OWNERS files. sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. labels Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/infra/azure Issues or PRs related to Kubernetes Azure infrastructure area/infra Infrastructure management, infrastructure design, code in infra/ cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants