Reconciling azure terraform state with what is actually deployed to azure

[marosset]

There has been a lot of drift between what is actually deployed in the azure CNCF sub and what is listed in the terraform config and this PR aims to reconcile that.

There were a few PRs that went stale such as

• add role assignments for gmsa creds #7101
• Adding private acr creds #7102

As well as other updates to address breaking changes in the terraform resource specifications.

[marosset]

OK - These changes should be ready to review.

Now when I run terraform plan I only see the following changes that will get applied

Terraform used the selected providers to generate the following execution plan. Resource actions are indicated with the following symbols:
  ~ update in-place

Terraform will perform the following actions:

  # module.capz_monitoring.azurerm_kubernetes_cluster.capz-monitoring will be updated in-place
  ~ resource "azurerm_kubernetes_cluster" "capz-monitoring" {
        id                                  = "/subscriptions/46678f10-4bbb-447e-98e8-d2829589f2d8/resourceGroups/capz-monitoring/providers/Microsoft.ContainerService/managedClusters/capz-monitoring"
        name                                = "capz-monitoring"
      ~ tags                                = {
          - "DO-NOT-DELETE" = "contact capz"
        } -> (known after apply)
        # (36 unchanged attributes hidden)

      ~ web_app_routing {
          ~ dns_zone_ids             = [
              ~ "/subscriptions/46678f10-4bbb-447e-98e8-d2829589f2d8/resourceGroups/capz-monitoring/providers/Microsoft.Network/dnszones/capz-monitoring.org" -> "/subscriptions/46678f10-4bbb-447e-98e8-d2829589f2d8/resourceGroups/capz-monitoring/providers/Microsoft.Network/dnsZones/capz-monitoring.org",
            ]
            # (2 unchanged attributes hidden)
        }

        # (6 unchanged blocks hidden)
    }

  # module.role_assignments.azurerm_role_assignment.acr_pull_private[0] has moved to module.role_assignments.azurerm_role_assignment.acr_pull_private
    resource "azurerm_role_assignment" "acr_pull_private" {
        id                                     = "/subscriptions/46678f10-4bbb-447e-98e8-d2829589f2d8/resourceGroups/capz-ci/providers/Microsoft.ContainerRegistry/registries/e2eprivatecommunity/providers/Microsoft.Authorization/roleAssignments/d555c53e-c50f-4d12-fec0-0c962a914404"
        name                                   = "d555c53e-c50f-4d12-fec0-0c962a914404"
        # (9 unchanged attributes hidden)
    }

Plan: 0 to add, 1 to change, 0 to destroy.

One is just a casing issue (dnszones -> dnsZones) and the other is a deleted tag but the tag is in the terraform config so I'm not entirely sure what is going on with that...

[marosset]

/assign @jsturtevant @jackfrancis @nojnhuh

[marosset]

I'm adding the terraform lock file because this is recommended by terraform

Terraform has created a lock file .terraform.lock.hcl to record the provider
selections it made above. Include this file in your version control repository
so that Terraform can guarantee to make the same selections by default when
you run "terraform init" in the future.

[jsturtevant]

not sure why you added this specifically, but I just a note that I had to still switch my az cli login to the correct sub to run terraform init. But this does make it clear that this is the sub we wish to be operating on in the rest of the scripts.

[marosset]

I was having issues where terraform wasn't picking up the subscription from my az cli login context.
I don't remember what exactly the error was but this fixed it.

[jsturtevant]

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jsturtevant, marosset
Once this PR has been reviewed and has the lgtm label, please assign xmudrii for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• infra/azure/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[marosset]

/assign @ameukam @BenTheElder @dims
Could you us get this PR merged?
Thanks!