Skip to content

Add 1.35 Release Signal shadows to appropriate mailing lists #8556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add 1.35 Release Signal shadows to appropriate mailing lists #8556

wants to merge 1 commit into from
+12 −8

Conversation

tico88612
Copy link
Member

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 24, 2025
@k8s-ci-robot k8s-ci-robot added area/access Define who has access to what via IAM bindings, role bindings, policy, etc. area/groups Google Groups management, code in groups/ area/release-eng Issues or PRs related to the Release Engineering subproject sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. sig/release Categorizes an issue or PR as relevant to SIG Release. labels Sep 24, 2025
@tico88612
Copy link
Member Author

/cc @drewhagen @katcosgrove

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 25, 2025
@tico88612
Add 1.35 Release Signal shadows
351b7f4 
Signed-off-by: ChengHao Yang <[email protected]>
@tico88612 tico88612 force-pushed the update/release-signal-mail-group branch from e92eb05 to 351b7f4 Compare September 25, 2025 11:57
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 25, 2025
@katcosgrove
Copy link
Contributor

/lgtm
/assign @justaugustus

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 25, 2025
justaugustus
justaugustus suggested changes Sep 25, 2025
View reviewed changes
Copy link
Member

@justaugustus justaugustus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tico88612 — Can we remove the v1.34 personnel (that are not participating in v1.35) from these lists?

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 25, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: tico88612
Once this PR has been reviewed and has the lgtm label, please ask for approval from justaugustus. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tico88612
Copy link
Member Author

@justaugustus I'm not familiar with the status of other sub-teams; some might be returning shadows. If you prefer to remove it, I can assist it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@puerco puerco Awaiting requested review from puerco

@saschagrunert saschagrunert Awaiting requested review from saschagrunert

@drewhagen drewhagen Awaiting requested review from drewhagen

@katcosgrove katcosgrove Awaiting requested review from katcosgrove

1 more reviewer

@justaugustus justaugustus justaugustus requested changes

Reviewers whose approvals may not affect merge requirements
Assignees

@justaugustus justaugustus

@katcosgrove katcosgrove

Labels
area/access Define who has access to what via IAM bindings, role bindings, policy, etc. area/groups Google Groups management, code in groups/ area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. sig/release Categorizes an issue or PR as relevant to SIG Release. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tico88612 @katcosgrove @k8s-ci-robot @justaugustus