Skip to content

fix nginx configuration and add a verify script #8567

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 26, 2025
Merged

fix nginx configuration and add a verify script #8567

merged 1 commit into from
Sep 26, 2025
+78 −5

Conversation

dims
Copy link
Member

@dims dims commented Sep 26, 2025

Fix for problems with nginx config filed in PR:
#8109

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 26, 2025
@k8s-ci-robot k8s-ci-robot added area/apps Application management, code in apps/ area/bash Bash scripts, testing them, writing less of them, code in infra/gcp/ approved Indicates a PR has been approved by an approver from all required OWNERS files. sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 26, 2025
@dims dims force-pushed the fix-nginx-configuration-and-add-a-verify-script branch from f8a4dce to 39627d2 Compare September 26, 2025 02:05
@dims dims force-pushed the fix-nginx-configuration-and-add-a-verify-script branch from 39627d2 to ce0d7f4 Compare September 26, 2025 02:10
xmudrii
xmudrii approved these changes Sep 26, 2025
View reviewed changes
Copy link
Member

@xmudrii xmudrii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 26, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, xmudrii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 1e858ed into kubernetes:main Sep 26, 2025
6 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.35 milestone Sep 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xmudrii xmudrii xmudrii approved these changes

@BenTheElder BenTheElder Awaiting requested review from BenTheElder

@upodroid upodroid Awaiting requested review from upodroid

Assignees

@xmudrii xmudrii

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apps Application management, code in apps/ area/bash Bash scripts, testing them, writing less of them, code in infra/gcp/ cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.35
Development

Successfully merging this pull request may close these issues.
3 participants
@dims @k8s-ci-robot @xmudrii