Merge pull request #16389 from rifelpet/toolbox-dump-error

Continue attemps to dump artifacts in `toolbox dump`
kubernetes · Feb 28, 2024 · 2e72309 · 2e72309
2 parents 7385490 + 045bd49
commit 2e72309
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/cmd/kops/toolbox_dump.go b/cmd/kops/toolbox_dump.go
@@ -232,7 +232,7 @@ func RunToolboxDump(ctx context.Context, f commandutils.Factory, out io.Writer,
 		}
 
 		if err := dumper.DumpAllNodes(ctx, nodes, options.MaxNodes, additionalIPs, additionalPrivateIPs); err != nil {
-			return fmt.Errorf("error dumping nodes: %v", err)
+			klog.Warningf("error dumping nodes: %v", err)
 		}
 
 		if kubeConfig != nil && options.K8sResources {
@@ -241,15 +241,15 @@ func RunToolboxDump(ctx context.Context, f commandutils.Factory, out io.Writer,
 				return fmt.Errorf("error creating resource dumper: %w", err)
 			}
 			if err := dumper.DumpResources(ctx); err != nil {
-				return fmt.Errorf("error dumping resources: %w", err)
+				klog.Warningf("error dumping resources: %v", err)
 			}
 
 			logDumper, err := dump.NewPodLogDumper(kubeConfig, options.Dir)
 			if err != nil {
 				return fmt.Errorf("error creating pod log dumper: %w", err)
 			}
 			if err := logDumper.DumpLogs(ctx); err != nil {
-				return fmt.Errorf("error dumping pod logs: %w", err)
+				klog.Warningf("error dumping pod logs: %v", err)
 			}
 		}
 	}