Skip to content

Commit

Permalink
Merge pull request #17220 from justinsb/remove_reconcile_flag
Browse files Browse the repository at this point in the history
Remove reconcile flag from `kops update`
  • Loading branch information
k8s-ci-robot authored Jan 20, 2025
2 parents 2cbe03b + 5c2c304 commit 30c00ad
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 7 deletions.
6 changes: 0 additions & 6 deletions cmd/kops/update_cluster.go
Original file line number Diff line number Diff line change
Expand Up @@ -190,8 +190,6 @@ func NewCmdUpdateCluster(f *util.Factory, out io.Writer) *cobra.Command {
cmd.Flags().BoolVar(&options.Prune, "prune", options.Prune, "Delete old revisions of cloud resources that were needed during an upgrade")
cmd.Flags().BoolVar(&options.IgnoreKubeletVersionSkew, "ignore-kubelet-version-skew", options.IgnoreKubeletVersionSkew, "Setting this to true will force updating the kubernetes version on all instance groups, regardles of which control plane version is running")

cmd.Flags().BoolVar(&options.Reconcile, "reconcile", options.Reconcile, "Reconcile the cluster by rolling the control plane and nodes sequentially")

return cmd
}

Expand Down Expand Up @@ -219,10 +217,6 @@ func RunCoreUpdateCluster(ctx context.Context, f *util.Factory, out io.Writer, c
}

func RunUpdateCluster(ctx context.Context, f *util.Factory, out io.Writer, c *UpdateClusterOptions) (*UpdateClusterResults, error) {
if c.Reconcile {
return nil, RunReconcileCluster(ctx, f, out, &c.CoreUpdateClusterOptions)
}

results := &UpdateClusterResults{}

isDryrun := false
Expand Down
1 change: 0 additions & 1 deletion docs/cli/kops_update_cluster.md

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 30c00ad

Please sign in to comment.