Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support bootstrapping nodes using Public Key authentication #16141

Merged
merged 3 commits into from
Dec 1, 2023

Conversation

justinsb
Copy link
Member

@justinsb justinsb commented Nov 30, 2023

  • feat: Create CRD for Host
  • feat: Support PKI bootstrap

We modify the GCE TPM support to support signing with a fixed private key. The public key must be registered in a Host CRD instance (this will be done automatically by the enroll command).

This holds the public key for a bare-metal machine.  The alternative
is to store this in a secret, but a dedicated CRD works better with
RBAC - we would rather not grant permissions on secrets if we have an
alternative.
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Nov 30, 2023
@justinsb justinsb changed the title pki bootstrap Support bootstrapping nodes using Public Key authentication Nov 30, 2023
Similar to the TPM bootstrapping on GCE (indeed, a lot of the code is
modified from there), but we verify the PKI signature against a public
key in a Host CRD object.
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 1, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 1, 2023
@hakman
Copy link
Member

hakman commented Dec 1, 2023

/retest

@k8s-ci-robot k8s-ci-robot merged commit d5818e8 into kubernetes:master Dec 1, 2023
7 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.29 milestone Dec 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/api area/kops-controller area/nodeup cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants