Skip to content

Commit

Permalink
Add a cardinality question to the PR template
Browse files Browse the repository at this point in the history
Reviewing a pull request involves assesing in which way the introduced change
affects metrics cardinality. To ease the burder on the reviewer and to make
contributors aware of the constraint, this commit extends the pull request template
with a question about the effect on metrics cardinality.
  • Loading branch information
fpetkovski committed Jul 6, 2021
1 parent 7594278 commit fe23a07
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion .github/PULL_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@

**What this PR does / why we need it**:

**How does this change affect the cardinality of KSM**: *(increases, decreases or does not change cardinality)*

**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
Fixes #

0 comments on commit fe23a07

Please sign in to comment.