-
Notifications
You must be signed in to change notification settings - Fork 40.6k
Allow specifying a directory for image credential providers json configuration #131658
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow specifying a directory for image credential providers json configuration #131658
Conversation
This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
8f3dac4
to
ae3953d
Compare
/kind important-soon |
@dims: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
ae3953d
to
7804418
Compare
/priority important-soon |
I think the simple merging you had before would just error in validation if the same name got defined across files, and that's probably a better behavior (indicates an unexpected / not working configuration) |
will do! |
9ec8a2a
to
77927f3
Compare
/test pull-kubernetes-unit-windows-master |
77927f3
to
6d5de8e
Compare
/lgtm |
LGTM label has been added. Git tree hash: b5668fc60abc4f88b25ba7f850ec9e087096f17f
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First pass.
6d5de8e
to
d4a6e68
Compare
… configuration Signed-off-by: Davanum Srinivas <[email protected]>
d4a6e68
to
be6807e
Compare
@dims: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
/lgtm |
LGTM label has been added. Git tree hash: 3c452a775dfd82195f0904d1eba764b9956ef58f
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dims, enj, liggitt The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@micahhausler and i were chatting with some folks about this use case where there may be multiple credential providers, each with possibly their own configuration json files. So i wanted to check if it is as easy as it looks...
Some background:
image-credential-provider-config
and the binaryhttps://github.com/search?q=repo%3Aawslabs%2Famazon-eks-ami+%2Fimage-credential-provider-config%2F&type=code
https://github.com/search?q=repo%3Akubernetes-sigs%2Fimage-builder%20%2Fimage-credential-provider-config%2F&type=code
So why not support more than one json file? just like we already do for binaries (
image-credential-provider-bin-dir
is a directory).What type of PR is this?
/kind feature
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: