-
Notifications
You must be signed in to change notification settings - Fork 40.7k
Migrate to declarative validation: ReplicationController/scale spec.replicas field #131664
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate to declarative validation: ReplicationController/scale spec.replicas field #131664
Conversation
This PR may require API review. If so, when the changes are ready, complete the pre-review checklist and request an API review. Status of requested reviews is tracked in the API Review project. |
/triage approved |
@aaron-prindle: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/triage accepted |
0731ff2
to
8b75cdc
Compare
/test pull-kubernetes-e2e-kind-alpha-features |
8b75cdc
to
20bfb66
Compare
06f0352
to
81a0757
Compare
Rebased and squashed. |
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I meant to send this comment before - not sure how I missed it.
81a0757
to
1d17ca9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM label has been added. Git tree hash: 20a4262d166730b83c9df3a56e03c02b39f67514
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jpbetz, thockin The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold cancel |
/retest |
What type of PR is this?
/kind feature
What this PR does / why we need it:
Migrates the ReplicationController's scale subresource to declarative validation.
Adds:
+k8s:supportsSubresource
(used to declare that the validation on a type also supports validation of a "status type subresource" subresource of that type)+k8s:isSubresource
(used to declare that the validation on a type IS for a specific "scale type subresource")Example usages:
To allow a subresource to be validated by root resource, add it as a supportedSubresource. For example, to allow the ReplicationController to validate both the scale and status subresource, use:
To identify a type as a subresource kind, mark it with isSubresource. For example:
Special notes for your reviewer:
Does this PR introduce a user-facing change?
/sig api-machinery