test: add batch pod deletion for kubelet e2e tests #132980

ylink-lfs · 2025-07-16T01:27:57Z

What type of PR is this?

/kind cleanup
/sig node
/sig tests
/priority backlog

What this PR does / why we need it:

e2e test simplicity and speedup purpose

Which issue(s) this PR is related to:

Clean up e2e pods in parallel #132974

Special notes for your reviewer:

NONE

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

NONE

k8s-ci-robot · 2025-07-16T01:28:09Z

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

k8s-ci-robot · 2025-07-16T01:28:12Z

Hi @ylink-lfs. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

k8s-ci-robot · 2025-07-16T01:28:13Z

@ylink-lfs: The label(s) sig/tests cannot be applied, because the repository doesn't have them.

In response to this:

What type of PR is this?

/kind cleanup
/sig node
/sig tests
/prioroty backlog

What this PR does / why we need it:

e2e test simplicity and speedup purpose

Which issue(s) this PR is related to:

Clean up e2e pods in parallel #132974

Special notes for your reviewer:

NONE

Does this PR introduce a user-facing change?
NONE
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:
NONE

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

ylink-lfs · 2025-07-16T01:28:31Z

/assign tallclair

Copilot

Pull Request Overview

This PR introduces a batch deletion helper for pod cleanup in node e2e tests to streamline parallel pod removals and speed up test execution.

Replace sequential DeletePodWithWait calls with DeletePodWithWaitByBatch in node e2e test code
Add DeletePodWithWaitByBatch implementation in the framework with concurrent deletion logic
Update imports to include slices and sync for the new helper

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

File	Description
test/e2e/node/pod_resize.go	Swapped individual pod deletions for batch deletion calls
test/e2e/node/kubelet.go	Updated AfterEach cleanup to use batch deletion
test/e2e/framework/pod/delete.go	Added `DeletePodWithWaitByBatch` with concurrency support

Comments suppressed due to low confidence (1)

test/e2e/framework/pod/delete.go:61

The new batch deletion helper lacks unit or integration tests. Adding tests to verify parallel deletion behavior and correct error ordering would ensure this function works as expected under different conditions.

// DeletePodWithWaitByBatch deletes the passed-in pods, waits for the pod to be terminated, return deletion error if exists

test/e2e/framework/pod/delete.go

test/e2e/node/kubelet.go

k8s-ci-robot · 2025-07-16T13:56:40Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ylink-lfs
Once this PR has been reviewed and has the lgtm label, please assign pohly for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

test/e2e/framework/OWNERS
test/e2e/node/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot · 2025-07-16T14:17:51Z

@ylink-lfs: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-kubernetes-node-e2e-crio-cgrpv1-dra	`a271277`	link	false	`/test pull-kubernetes-node-e2e-crio-cgrpv1-dra`
pull-kubernetes-e2e-kind-alpha-beta-features	`a271277`	link	false	`/test pull-kubernetes-e2e-kind-alpha-beta-features`
pull-kubernetes-e2e-gce-storage-snapshot	`a271277`	link	false	`/test pull-kubernetes-e2e-gce-storage-snapshot`
pull-kubernetes-e2e-gce-network-policies	`a271277`	link	false	`/test pull-kubernetes-e2e-gce-network-policies`
pull-kubernetes-e2e-gce-cos-alpha-features	`a271277`	link	false	`/test pull-kubernetes-e2e-gce-cos-alpha-features`
pull-kubernetes-e2e-gci-gce-ingress	`a271277`	link	false	`/test pull-kubernetes-e2e-gci-gce-ingress`
pull-kubernetes-e2e-gce-csi-serial	`a271277`	link	false	`/test pull-kubernetes-e2e-gce-csi-serial`
pull-kubernetes-e2e-gce-storage-slow	`a271277`	link	false	`/test pull-kubernetes-e2e-gce-storage-slow`

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

ylink-lfs · 2025-07-16T14:21:21Z

/retest

k8s-triage-robot · 2025-07-16T14:36:42Z

This PR may require API review.

If so, when the changes are ready, complete the pre-review checklist and request an API review.

Status of requested reviews is tracked in the API Review project.

SergeyKanzhelev · 2025-07-16T17:27:24Z

test/e2e/framework/pod/delete.go

@@ -56,6 +57,20 @@ func DeletePodWithWait(ctx context.Context, c clientset.Interface, pod *v1.Pod)
 	return DeletePodWithWaitByName(ctx, c, pod.GetName(), pod.GetNamespace())
 }

+// DeletePodWithWaitByBatch deletes the passed-in pods, waits for the pod to be terminated, return deletion error if exists
+func DeletePodWithWaitByBatch(ctx context.Context, c clientset.Interface, pods []*v1.Pod) {


nit: should this be named like this:

Suggested change

func DeletePodWithWaitByBatch(ctx context.Context, c clientset.Interface, pods []*v1.Pod) {

func DeletePodsWithWaitByBatch(ctx context.Context, c clientset.Interface, pods []*v1.Pod) {

SergeyKanzhelev · 2025-07-16T17:33:00Z

test/e2e/framework/pod/delete.go

+			framework.ExpectNoError(DeletePodWithWait(ctx, c, pod), "Error deleting Pod %s", pod.GetName())
+		}(i, pod)
+	}
+	wg.Wait()


it may be a good improvement to fail test here instead of in each goroutine. This way test will clean up it's Pods more consistently, even if one of them failed to be deleted.

Copilot AI review requested due to automatic review settings July 16, 2025 01:27

k8s-ci-robot added the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Jul 16, 2025

k8s-ci-robot requested a review from andrewsykim July 16, 2025 01:28

k8s-ci-robot requested a review from derekwaynecarr July 16, 2025 01:28

k8s-ci-robot added sig/node Categorizes an issue or PR as relevant to SIG Node. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jul 16, 2025

github-project-automation bot added this to SIG Node: code and documentation PRs Jul 16, 2025

github-project-automation bot moved this to Triage in SIG Node: code and documentation PRs Jul 16, 2025

github-project-automation bot added this to SIG Node CI/Test Board Jul 16, 2025

github-project-automation bot moved this to Triage in SIG Node CI/Test Board Jul 16, 2025

k8s-ci-robot assigned tallclair Jul 16, 2025

Copilot AI reviewed Jul 16, 2025

View reviewed changes

test/e2e/framework/pod/delete.go Outdated Show resolved Hide resolved

test/e2e/node/kubelet.go Outdated Show resolved Hide resolved

test/e2e/node/kubelet.go Outdated Show resolved Hide resolved

ylink-lfs force-pushed the test/pod_delete_batch branch 2 times, most recently from 7057a13 to b11bf74 Compare July 16, 2025 01:58

k8s-ci-robot added priority/backlog Higher priority than priority/awaiting-more-evidence. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jul 16, 2025

k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jul 16, 2025

k8s-ci-robot removed area/apiserver area/code-generation area/conformance Issues or PRs related to kubernetes conformance tests area/ipvs area/kube-proxy area/release-eng Issues or PRs related to the Release Engineering subproject labels Jul 16, 2025

enj moved this to Needs Triage in SIG Auth Jul 16, 2025

ylink-lfs requested a review from HirazawaUi July 16, 2025 14:19

SergeyKanzhelev reviewed Jul 16, 2025

View reviewed changes

SergeyKanzhelev moved this from Triage to PRs - Needs Reviewer in SIG Node CI/Test Board Jul 16, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

test: add batch pod deletion for kubelet e2e tests #132980

test: add batch pod deletion for kubelet e2e tests #132980

ylink-lfs commented Jul 16, 2025 •

edited

Loading

Uh oh!

k8s-ci-robot commented Jul 16, 2025

Uh oh!

k8s-ci-robot commented Jul 16, 2025

Uh oh!

k8s-ci-robot commented Jul 16, 2025

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR is related to:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

Uh oh!

ylink-lfs commented Jul 16, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

k8s-ci-robot commented Jul 16, 2025

Uh oh!

k8s-ci-robot commented Jul 16, 2025 •

edited

Loading

Uh oh!

ylink-lfs commented Jul 16, 2025

Uh oh!

k8s-triage-robot commented Jul 16, 2025

Uh oh!

SergeyKanzhelev Jul 16, 2025

Uh oh!

SergeyKanzhelev Jul 16, 2025

Uh oh!

Uh oh!

	func DeletePodWithWaitByBatch(ctx context.Context, c clientset.Interface, pods []*v1.Pod) {
	func DeletePodsWithWaitByBatch(ctx context.Context, c clientset.Interface, pods []*v1.Pod) {

test: add batch pod deletion for kubelet e2e tests #132980

Are you sure you want to change the base?

test: add batch pod deletion for kubelet e2e tests #132980

Conversation

ylink-lfs commented Jul 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR is related to:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

Uh oh!

k8s-ci-robot commented Jul 16, 2025

Uh oh!

k8s-ci-robot commented Jul 16, 2025

Uh oh!

k8s-ci-robot commented Jul 16, 2025

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR is related to:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

Uh oh!

ylink-lfs commented Jul 16, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

k8s-ci-robot commented Jul 16, 2025

Uh oh!

k8s-ci-robot commented Jul 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ylink-lfs commented Jul 16, 2025

Uh oh!

k8s-triage-robot commented Jul 16, 2025

Uh oh!

SergeyKanzhelev Jul 16, 2025

Choose a reason for hiding this comment

Uh oh!

SergeyKanzhelev Jul 16, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

ylink-lfs commented Jul 16, 2025 •

edited

Loading

k8s-ci-robot commented Jul 16, 2025 •

edited

Loading