-
Notifications
You must be signed in to change notification settings - Fork 41.6k
Enable nomaps rule for Kube API Linter #134852
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Enable nomaps rule for Kube API Linter #134852
Conversation
|
This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Hi @MatteoFari. Thanks for your PR. I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: MatteoFari The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/ok-to-test |
|
/release-note-none |
|
/hold |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wasn't expecting there to be too many violations for this linter, can we get a count per API group that you've added an exclude for please?
| path: "staging/src/k8s.io/api/networking/v1beta1/types.go" | ||
| path: "staging/src/k8s.io/api/networking/v1beta1/types.go" | ||
|
|
||
| # nomaps is being enabled over time. For now, each API group should be added to this list until we comb through each group and fix/ignore the issues. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How many different violations are there in these groups?
0bd4b10 to
40734a7
Compare
hack/kube-api-linter/exceptions.yaml
Outdated
|
|
||
| # nomaps - Permanent exception for stable (v1), older (v1beta1) and v1alpha1. | ||
| # This cannot be changed due to backward compatibility constraints. | ||
| - text: "should not use a map type, use a list type with a unique name/identifier instead" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To be properly scoped and effective here, we need to include the field names in the error messages. So I think lets try break this down further please, else we risk ignoring new violations in these groups
40734a7 to
d7cbfee
Compare
|
@JoelSpeed I added the field names in the error messages so now it's better scoped. Let me know if I can go on doing the same for core and resource or should proceed in a different way. |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Enable nomaps for Kubernetes API Linter with all the exceptions
Which issue(s) this PR is related to:
Part of #134671
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: