Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(kmsgLogWatcher): add logger to parser #1009

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions pkg/systemlogmonitor/logwatchers/kmsg/log_watcher_linux.go
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,8 @@ func (k *kernelLogWatcher) Watch() (<-chan *logtypes.Log, error) {
if err != nil {
return nil, fmt.Errorf("failed to create kmsg parser: %v", err)
}
// set kmsg parser logger to klog
parser.SetLogger(&kmsgParserLogger{})
k.kmsgParser = parser
}

Expand Down
21 changes: 21 additions & 0 deletions pkg/systemlogmonitor/logwatchers/kmsg/logger.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
package kmsg

import (
"k8s.io/klog/v2"
)

// kmsgParserLogger is compatible with the kmsgparser.Logger interface
// redirecting the log messages to klog
type kmsgParserLogger struct{}

func (k *kmsgParserLogger) Infof(format string, args ...interface{}) {
klog.Infof(format, args...)
}

func (k *kmsgParserLogger) Errorf(format string, args ...interface{}) {
klog.Errorf(format, args...)
}

func (k *kmsgParserLogger) Warningf(format string, args ...interface{}) {
klog.Warningf(format, args...)
}