feature: add custom message for systemlogmonitor rule #997
Conversation
k8s-ci-robot
added
kind/feature
k8s-ci-robot
added
the
size/M
|
friendly ping @wangzhen127 @hakman @andyxning |
pkg/systemlogmonitor/types/types.go
Outdated
| @@ -42,4 +42,7 @@ type Rule struct { | |||
| // Pattern is the regular expression to match the problem in log. | |||
| // Notice that the pattern must match to the end of the line. | |||
| Pattern string `json:"pattern"` | |||
| // Message is an optional static message to append to the matching log message. | |||
| // This can provide additional context or instructions for resolving the issue. | |||
| Message string `json:"message,omitempty"` | |||
There was a problem hiding this comment.
rename Message name to UserDefinedAdditionalMatchingLogMessage?
There was a problem hiding this comment.
maybe PatternSuffix or PatternMessage is better ? 🤔
Because our new field is actually an extended info
There was a problem hiding this comment.
PatternGeneratedMessageSuffix?
There was a problem hiding this comment.
also the comment and code should be adjusted.
googs1025
force-pushed
the
monitor_log
branch
from
8993460 to
f5433f4
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andyxning, googs1025 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
/kind feature
Fix: #979