sig-instrumentation: Add lilic to approvers

[brancz]

@logicalhan

[logicalhan]

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brancz, logicalhan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• config/kubernetes/sig-instrumentation/OWNERS [brancz,logicalhan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[lilic]

Thanks! 🙇‍♀️ :)

[k8s-ci-robot]

@brancz: The following test failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
pull-org-test-all	cfd603a	link	/test pull-org-test-all

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[ehashman]

List needs to be alphabetized, which is why CI is failing.

@lilic is not an approver in k/k (where this list was pulled from---these are approvers in the kubernetes/ org) but is in kubernetes-sigs as KSM subproject owner. Should we be adding her here or to a kubernetes-sigs team?

I guess technically KSM is still in the kubernetes org but it's not supposed to be... :)

/hold
for discussion

(edit: basically, my intent for this team was that people have an alias that they can @ for a SIG Instrumentation approver, which would typically be in k/k, and @lilic doesn't have reviewer/approver there, so she'll end up getting non-actionable pings. There's some issues in kubernetes/steering#200 and kubernetes/community#5722 tracking better recognition for subproject owners.)

[brancz]

This has nothing to do with kube-state-metrics, @lilic has reviewed plenty of instrumentation-related PRs and I want her to be able to approve any sig instrumentation-related PRs, because I trust whatever review she does, and it distributes the load. I don't know if this PR does that, but it's what I found searching through the org, if this PR does not reflect my intention, can you point out what needs to be different?

[ehashman]

https://github.com/kubernetes/kubernetes/blob/6dd9deea3daa98e0003878544372b2c1b9e0e03d/OWNERS_ALIASES#L319-L336

Lili currently isn't listed as either an instrumentation reviewer or approver. We should fix that first before adding her to the GitHub team.

[ehashman]

So, to be clear, this PR doesn't actually add any rights or responsibilities, it would just add another user to the GitHub team. I think as proposed it's a bit confusing for the reasons stated above. If we want to make OWNERS files changes, we should be following the community membership guidelines.

I would also like to see @lilic become an OWNER in k/k if that is something she's interested in doing. If that's the case, I think the next steps here are:

• add @lilic as a reviewer to k/k right now
• follow up with approver access in 3mo

I have great respect and appreciation for @lilic's work, and I would be delighted for you to take on more responsibility in SIG Instrumentation.

[brancz]

For the record, Lili has been active in sig instrumentation for well over two years. I don't think us missing out on adding her to be a reviewer long ago is totally our mistake, and I think it's wrong not to acknowledge that mistake. I think this type of reaction makes us loose community members.