Skip to content

Add cloud build #3386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add cloud build #3386

wants to merge 1 commit into from

Conversation

mkumatag
Copy link
Member

@mkumatag mkumatag commented Jun 9, 2025

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #3376

Special notes for your reviewer:

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jun 9, 2025
@k8s-ci-robot k8s-ci-robot requested review from mborsz and shyamjvs June 9, 2025 17:51
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 9, 2025
@mkumatag mkumatag changed the title Add cloud build [WIP] Add cloud build Jun 9, 2025
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 9, 2025
@mkumatag
Copy link
Member Author

mkumatag commented Jun 9, 2025

/cc @ameukam

@k8s-ci-robot k8s-ci-robot requested a review from ameukam June 9, 2025 17:54
@ameukam
Copy link
Member

ameukam commented Jun 9, 2025

Thank you so much!
/lgtm
/assign @marseel

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 9, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ameukam, mkumatag
Once this PR has been reviewed and has the lgtm label, please assign marseel for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mkumatag
Copy link
Member Author

need kubernetes/test-infra#34957 to be merged to trigger the build for these images

@mkumatag mkumatag changed the title [WIP] Add cloud build Add cloud build Jun 10, 2025
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 10, 2025
@mkumatag
Copy link
Member Author

need kubernetes/test-infra#34957 to be merged to trigger the build for these images

/hold for this ^^

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 10, 2025
@mkumatag
Copy link
Member Author

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 10, 2025
@mkumatag
Copy link
Member Author

This PR is ready to merge!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate away from gcr.io/k8s-testimages repo
4 participants