-
Notifications
You must be signed in to change notification settings - Fork 609
Add logging for dns lookups with timestamps #3631
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add logging for dns lookups with timestamps #3631
Conversation
Hi @Tanzp01. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
cc @bowei the owner of this directory |
/assign @bowei |
/ok-to-test |
d09cd73
to
65b188b
Compare
/lgtm /assign @tosi3k |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unrelated comment:
- There is what looks like abandoned code in comments at the bottom -- I would send another PR to delete it.
- The timedOut variable looks weird to me but don't fix it in this change.
added err in infoLogger, changed latency to milliseconds cleanup in "name" and ".Error()" for maintainance
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems like there are a few more minor comments that are open.
/approve Seems like there are some minor comments that are still open |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bowei, jprzychodzen, marqc, Tanzp01 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Added 2 structured loggings for:
What type of PR is this?
/kind feature
What this PR does / why we need it:
To better analyse the performance of DNS over time
Special notes for your reviewer:
There were existing loggings, but not structured. I added these 2 opt-in structured logging while keeping the previous loggings, so that any existing analysis based on the logging won't be affected