Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump go version #96

Merged
merged 2 commits into from
Aug 16, 2022
Merged

Bump go version #96

merged 2 commits into from
Aug 16, 2022

Conversation

ameukam
Copy link
Member

@ameukam ameukam commented Aug 11, 2022

Bump go version and components used for tests

Signed-off-by: Arnaud Meukam [email protected]

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 11, 2022
@k8s-ci-robot k8s-ci-robot requested review from BobyMCbobs and hh August 11, 2022 22:08
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 11, 2022
@ameukam
Copy link
Member Author

ameukam commented Aug 11, 2022

cc @BenTheElder

@BenTheElder
Copy link
Member

there's a new lint failure. https://github.com/kubernetes-sigs/oci-proxy/pull/21/files needs to be extended to ReadHeaderTimeout

BenTheElder
BenTheElder approved these changes Aug 11, 2022
View reviewed changes
Copy link
Member

@BenTheElder BenTheElder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 11, 2022
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 11, 2022
ameukam added 2 commits August 16, 2022 17:17
@ameukam
Bump go version
e35fec1 
Bump go version and components used for tests

Signed-off-by: Arnaud Meukam <[email protected]>
@ameukam
Add ReadHeaderTimeout to prevent Slowloris attack
610a94d 
Signed-off-by: Arnaud Meukam <[email protected]>
@ameukam
Copy link
Member Author

ameukam commented Aug 16, 2022

gimme is currently not supporting 1.19 (not working with 1.19). I'll switch to 1.19 when travis-ci/gimme#203 is merged.

cc @dims

BenTheElder
BenTheElder reviewed Aug 16, 2022
View reviewed changes
Copy link
Member

@BenTheElder BenTheElder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/shrug
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added ¯\_(ツ)_/¯ ¯\\\_(ツ)_/¯ lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Aug 16, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ameukam, BenTheElder

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [BenTheElder,ameukam]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@BenTheElder
Copy link
Member

gimme is currently not supporting 1.19 (not working with 1.19). I'll switch to 1.19 when travis-ci/gimme#203 is merged.

that should not be the case? I have 1.19 in kind with the same tooling https://github.com/kubernetes-sigs/kind/blob/main/.go-version

@BenTheElder
Copy link
Member

BenTheElder commented Aug 16, 2022 •
edited
Loading

gimme does not need to know that a go version exists to download it, you just need to make sure to use 1.19 not 1.19.0 (1.19.0 is not a go version) https://github.com/kubernetes-sigs/kind/blob/main/hack/third_party/gimme/gimme is two years old and working fine

@k8s-ci-robot k8s-ci-robot merged commit 8293873 into kubernetes:main Aug 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BenTheElder BenTheElder BenTheElder approved these changes

@BobyMCbobs BobyMCbobs Awaiting requested review from BobyMCbobs

@hh hh Awaiting requested review from hh

Assignees

@BenTheElder BenTheElder

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. ¯\_(ツ)_/¯ ¯\\\_(ツ)_/¯
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ameukam @BenTheElder @k8s-ci-robot