Adding tests for specs in obs package

[TatianaSelezneva]

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

We are missing unit tests for krel obs and this PR attempts to improve coverage
Relevant card from the project board: #3168

This is part 4 of the tests, previously tests we added for obs.go file here and here and here

Which issue(s) this PR fixes:

It improves unit test coverage for the krel obs

Special notes for your reviewer:

PR includes tests for obs/specs/spec.go and obs/specs/pkgdef.go.
We will also need tests for obs/specs/template.go and obs/specs/archive.go.
I'll add those tests in the follow-up PR to keep this PR small-ish.

I'll also add test coverage for Run function in spec.go later. From 'Runfunction we callBuildSpecsandBuildArtifactsArchivewhich are defined intemplate.goandarchive.go` mentioned above (they are still missing tests). They don't have fakes, so to set up tests I need some implementation knowledge.

It will be easier to add tests for 'Run()' after I added tests for template.go and archive.go.

Does this PR introduce a user-facing change?

NONE

cc @xmudrii for feedback

[k8s-ci-robot]

Hi @TatianaSelezneva. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[xmudrii]

/test all

[xmudrii]

/release-note-edit

NONE

[k8s-ci-robot]

@xmudrii: /release-note-edit must be used with a single release note block.

In response to this:

/release-note-edit

NONE

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[xmudrii]

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: TatianaSelezneva, xmudrii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• pkg/OWNERS [xmudrii]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment