Skip to content

Commit

Permalink
node dra: run_if_changed only for Go source code
Browse files Browse the repository at this point in the history
These pre-submit checks are more useful when someone actually modifies source
code and less useful for other changes (Go dependencies, Markdown).
  • Loading branch information
pohly committed Dec 13, 2024
1 parent 4a41917 commit 229f05c
Showing 1 changed file with 7 additions and 8 deletions.
15 changes: 7 additions & 8 deletions config/jobs/kubernetes/sig-node/sig-node-presubmit.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3202,7 +3202,7 @@ presubmits:
always_run: false
# This covers most of the code related to dynamic resource allocation.
# Periodic variant: ci-kind-dra
run_if_changed: /dra/|/dynamicresources/|/resourceclaim/|/resourceclass/|/podscheduling/|/resourceclaimtemplate/|/dynamic-resource-allocation/|/pkg/apis/resource/|/api/resource/
run_if_changed: /(dra|dynamicresources|resourceclaim|deviceclass|resourceslice|resourceclaimtemplate|dynamic-resource-allocation|pkg/apis/resource|api/resource)/.*.go
# The tests might still be flaky or this job might get triggered accidentally for
# an unrelated PR.
optional: true
Expand Down Expand Up @@ -3259,7 +3259,7 @@ presubmits:
always_run: false
# This covers most of the code related to dynamic resource allocation.
# Periodic variant: ci-kind-dra-all
run_if_changed: /dra/|/dynamicresources/|/resourceclaim/|/resourceclass/|/podscheduling/|/resourceclaimtemplate/|/dynamic-resource-allocation/|/pkg/apis/resource/|/api/resource/
run_if_changed: /(dra|dynamicresources|resourceclaim|deviceclass|resourceslice|resourceclaimtemplate|dynamic-resource-allocation|pkg/apis/resource|api/resource)/.*.go
# The tests might still be flaky or this job might get triggered accidentally for
# an unrelated PR.
optional: true
Expand Down Expand Up @@ -4281,7 +4281,7 @@ presubmits:
# Automatically testing with one container runtime in one configuration is sufficient to detect basic problems in kubelet early.
# CRI-O was picked because it was solid for testing so far.
# Periodic variant: ci-node-e2e-crio-cgrpv1-dra-features
run_if_changed: /dra/|/dynamicresources/|/resourceclaim/|/resourceclass/|/podscheduling/|/resourceclaimtemplate/|/dynamic-resource-allocation/|/pkg/apis/resource/|/api/resource/|/test/e2e_node/dra_test.go
run_if_changed: (/dra/|/dynamicresources/|/resourceclaim/|/deviceclass/|/resourceslice/|/resourceclaimtemplate/|/dynamic-resource-allocation/|/pkg/apis/resource/|/api/resource/|/test/e2e_node/dra_).*\.(go|yaml)
optional: true
skip_report: false
labels:
Expand Down Expand Up @@ -4332,7 +4332,7 @@ presubmits:
# explicitly needs /test pull-kubernetes-node-e2e-crio-cgrpv1-dra-kubetest2 to run
always_run: false
# Don't run automatically while experimental!
# run_if_changed: /dra/|/dynamicresources/|/resourceclaim/|/resourceclass/|/podscheduling/|/resourceclaimtemplate/|/dynamic-resource-allocation/|/pkg/apis/resource/|/api/resource/|/test/e2e_node/dra_test.go
# run_if_changed: (/dra/|/dynamicresources/|/resourceclaim/|/deviceclass/|/resourceslice/|/resourceclaimtemplate/|/dynamic-resource-allocation/|/pkg/apis/resource/|/api/resource/|/test/e2e_node/dra_).*\.(go|yaml)
optional: true
skip_report: false
skip_branches:
Expand Down Expand Up @@ -4389,7 +4389,7 @@ presubmits:
# Automatically testing with one container runtime in one configuration is sufficient to detect basic problems in kubelet early.
# CRI-O was picked because it was solid for testing so far.
# Periodic variant: ci-node-e2e-cgrpv2-crio-dra
# run_if_changed: /dra/|/dynamicresources/|/resourceclaim/|/resourceclass/|/podscheduling/|/resourceclaimtemplate/|/dynamic-resource-allocation/|/pkg/apis/resource/|/api/resource/|/test/e2e_node/dra_test.go
# run_if_changed: (/dra/|/dynamicresources/|/resourceclaim/|/deviceclass/|/resourceslice/|/resourceclaimtemplate/|/dynamic-resource-allocation/|/pkg/apis/resource/|/api/resource/|/test/e2e_node/dra_).*\.(go|yaml)
optional: true
skip_report: false
labels:
Expand Down Expand Up @@ -4440,7 +4440,7 @@ presubmits:
# explicitly needs /test pull-kubernetes-node-e2e-crio-cgrpv2-dra-kubetest2 to run
always_run: false
# Don't run automatically while experimental!
# run_if_changed: /dra/|/dynamicresources/|/resourceclaim/|/resourceclass/|/podscheduling/|/resourceclaimtemplate/|/dynamic-resource-allocation/|/pkg/apis/resource/|/api/resource/|/test/e2e_node/dra_test.go
# run_if_changed: (/dra/|/dynamicresources/|/resourceclaim/|/deviceclass/|/resourceslice/|/resourceclaimtemplate/|/dynamic-resource-allocation/|/pkg/apis/resource/|/api/resource/|/test/e2e_node/dra_).*\.(go|yaml)
optional: true
skip_report: false
skip_branches:
Expand Down Expand Up @@ -4497,8 +4497,7 @@ presubmits:
# Automatically testing with one container runtime in one configuration is sufficient to detect basic problems in kubelet early.
# CRI-O was picked because it was solid for testing so far.
# Periodic variant: ci-node-e2e-containerd-1-7-dra
# run_if_changed: /dra/|/dynamicresources/|/resourceclaim/|/resourceclass/|/podscheduling/|/resourceclaimtemplate/|/dynamic-resource-allocation/|/pkg/apis/resource/|/api/resource/|/test/e2e_node/dra_test.go
optional: true
# run_if_changed: (/dra/|/dynamicresources/|/resourceclaim/|/deviceclass/|/resourceslice/|/resourceclaimtemplate/|/dynamic-resource-allocation/|/pkg/apis/r optional: true
skip_report: false
labels:
preset-service-account: "true"
Expand Down

0 comments on commit 229f05c

Please sign in to comment.