Skip to content

Commit

Permalink
Exclude Alpha|Beta features from pull-kubernetes-e2e-gce-network-poli…
Browse files Browse the repository at this point in the history
…cies (#33451)

* Exclude Alpha|Beta features from pull-kubernetes-e2e-gce-network-policies

Follow up to #33450

This test still ran, despite excluding Alpha/Beta:
```
[sig-network] [Feature:ServiceCIDRs] [FeatureGate:MultiCIDRServiceAllocator] [Beta] [It] should create Services and serve on different Service CIDRs [sig-network, Feature:ServiceCIDRs, FeatureGate:MultiCIDRServiceAllocator, Feature:Beta]
```

I think the tags before and after the description are differnt, but I'm
not sure why.

Testing this locally seems to work, that one test is now excluded.
I'm a little worried about the special characters in the command line,
but unsure how to test those here.

* Satisfy yaml parsing

* Use ginkgo.label-filter as much as possible

For the tests that I could, I moved from string matching (with
ginkgo.skip) to label matching (with ginkgo.label-filter).

A few tests don't have labels to match, so they remain being filtered
out using ginkgo.label-filter

* Update config/jobs/kubernetes/sig-network/sig-network-misc.yaml

---------

Co-authored-by: Antonio Ojea <[email protected]>
  • Loading branch information
adrianmoisey and aojea authored Sep 10, 2024
1 parent 60cb826 commit 3e07b1a
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion config/jobs/kubernetes/sig-network/sig-network-misc.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,8 @@ presubmits:
- --provider=gce
# Skipping snat tests probably GCE related? https://github.com/kubernetes/test-infra/issues/20321
# Skipping Cloud Provider specific tests: LoadBalancer, ESIPP (Source IP Preservation)
- --test_args=--ginkgo.focus=\[sig-network\]|\[Conformance\]|\[Feature:NetworkPolicy\]|\[Feature:NetworkPolicyEndPort\] --ginkgo.skip=\[Feature:(Alpha|Beta|Networking-IPv6|Example|Federation|PerformanceDNS|KubeProxyDaemonSetMigration|SCTPConnectivity)\]|DualStack|GCE|Disruptive|Serial|SNAT|LoadBalancer|ESIPP
- >
--test_args=--ginkgo.skip=GCE|Disruptive|Serial|SNAT --ginkgo.label-filter='(sig-network || Conformance || Feature: containsAny {NetworkPolicy, NetworkPolicyEndPort} ) && !Feature: containsAny {Alpha, Beta, Example, Federation, IPv6DualStack, LoadBalancer, Networking-IPv6, PerformanceDNS, SCTPConnectivity, KubeProxyDaemonSetMigration}'
- --timeout=100m
image: gcr.io/k8s-staging-test-infra/kubekins-e2e:v20240903-6a352c5344-master
resources:
Expand Down

0 comments on commit 3e07b1a

Please sign in to comment.