-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
etcd: adjust govulncheck memory limits #33452
etcd: adjust govulncheck memory limits #33452
Conversation
The job gets stuck when running the govulncheck command at the repository's root. Following Grafana, it seems to be reaching the memory limit.
/cc @jmhbnz |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was on my list, I had noticed it having trouble. Thanks Ivan, let's see how it behaves with a bit more memory 🙏🏻
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ivanvc, jmhbnz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@ivanvc: Updated the
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@jmhbnz, it now failed as expected. Refer to: etcd-io/etcd#18573 (comment) Edit: scratch that, it seems to be another issue(?) |
That was a fluke. It worked as expected the second time: https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/etcd-io_etcd/18573/pull-etcd-govulncheck/1833616886273675264 |
The job gets stuck when running the
govulncheck
command at the repository's root. Following Grafana, it seems to be reaching the memory limit.Based on historical usage, I initially configured it to use at most 1Gi. However, usage seems to increase if there's a vulnerability in the code (right now, we should get a job failure because the main branch is still using Go 1.22.6).
Reference: