Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

etcd: adjust govulncheck memory limits #33452

Conversation

ivanvc
Copy link
Member

@ivanvc ivanvc commented Sep 10, 2024

The job gets stuck when running the govulncheck command at the repository's root. Following Grafana, it seems to be reaching the memory limit.

Based on historical usage, I initially configured it to use at most 1Gi. However, usage seems to increase if there's a vulnerability in the code (right now, we should get a job failure because the main branch is still using Go 1.22.6).

Reference:

The job gets stuck when running the govulncheck command at the
repository's root. Following Grafana, it seems to be reaching the memory
limit.
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/config Issues or PRs related to code in /config area/jobs sig/etcd Categorizes an issue or PR as relevant to SIG Etcd. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 10, 2024
@ivanvc
Copy link
Member Author

ivanvc commented Sep 10, 2024

/cc @jmhbnz

Copy link
Member

@jmhbnz jmhbnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was on my list, I had noticed it having trouble. Thanks Ivan, let's see how it behaves with a bit more memory 🙏🏻

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 10, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ivanvc, jmhbnz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 10, 2024
@k8s-ci-robot k8s-ci-robot merged commit d1204ea into kubernetes:master Sep 10, 2024
7 checks passed
@k8s-ci-robot
Copy link
Contributor

@ivanvc: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key etcd-presubmits.yaml using file config/jobs/etcd/etcd-presubmits.yaml

In response to this:

The job gets stuck when running the govulncheck command at the repository's root. Following Grafana, it seems to be reaching the memory limit.

Based on historical usage, I initially configured it to use at most 1Gi. However, usage seems to increase if there's a vulnerability in the code (right now, we should get a job failure because the main branch is still using Go 1.22.6).

Reference:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ivanvc ivanvc deleted the adjust-etcd-govulncheck-presubmit-job-ram branch September 10, 2024 21:12
@ivanvc
Copy link
Member Author

ivanvc commented Sep 10, 2024

@jmhbnz, it now failed as expected. Refer to: etcd-io/etcd#18573 (comment)

Edit: scratch that, it seems to be another issue(?)

@ivanvc
Copy link
Member Author

ivanvc commented Sep 10, 2024

That was a fluke. It worked as expected the second time: https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/etcd-io_etcd/18573/pull-etcd-govulncheck/1833616886273675264

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/etcd Categorizes an issue or PR as relevant to SIG Etcd. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants