Skip to content

Conversation

upodroid
Copy link
Member

@upodroid upodroid commented Oct 14, 2025

/hold

Requires kubernetes/kops#17671 to be merged first

Closes #35699

A concurrency limit is in place while the boskos-pool is growing; it will then be limited to 4.

/cc @alaypatel07 @BenTheElder @hakman

Also, ci-kubernetes-e2e-kops-gce-100-node-dra-with-workload-ipalias-using-cl2 will replace ci-kubernetes-e2e-gce-100-node-dra-extended-resources-with-workload once it's green.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 14, 2025
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 14, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: upodroid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. area/config Issues or PRs related to code in /config area/jobs sig/scalability Categorizes an issue or PR as relevant to SIG Scalability. sig/testing Categorizes an issue or PR as relevant to SIG Testing. wg/device-management Categorizes an issue or PR as relevant to WG Device Management. labels Oct 14, 2025
base_ref: master
path_alias: k8s.io/kubernetes
- org: alaypatel07
- org: kubernetes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you please drop this, its intended to use my branch until we have merged this: kubernetes/perf-tests#3629

- org: kubernetes
repo: perf-tests
base_ref: dra-extended-resources
base_ref: master
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you please drop this, its intended to use my branch until we have merged this: kubernetes/perf-tests#3629

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

- name: BOSKOS_RESOURCE_TYPE
value: "scalability-project"
- name: KOPS_CL2_TEST_CONFIG
value: testing/dra/config.yaml
Copy link
Contributor

@alaypatel07 alaypatel07 Oct 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need to preload that image? Is it too expensive to pull at runtime?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, pulling at runtime means that pod startup is breaching the 5 second SLO. More info here: https://docs.google.com/document/d/1YzPR3j0gxDNwL6iaY28trUsKVb2xyhrwHY-DqVcVaUE/edit?tab=t.0#heading=h.u5mis8uopyk2

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

value: "true"
- name: PROMETHEUS_PVC_STORAGE_CLASS
value: "ssd-csi"
- name: CLOUD_PROVIDER
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The DRA test also require enabling certain feature flags. From the config above this is set:

            - --env=KUBE_FEATURE_GATES=DynamicResourceAllocation=true

In the case of kops, should we be setting the KOPS_FEATURE_FLAGS feature flag with above?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DRA feature should be autoenabled already. kops does enable all GA/Beta flags by default

@upodroid
Copy link
Member Author

This is ready to be merged. I'll cancel the hold once the kops PR is merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. sig/scalability Categorizes an issue or PR as relevant to SIG Scalability. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. wg/device-management Categorizes an issue or PR as relevant to WG Device Management.

Projects

Status: 🆕 New

Development

Successfully merging this pull request may close these issues.

3 participants