-
Notifications
You must be signed in to change notification settings - Fork 2.8k
create new 5k dra job #35700
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
create new 5k dra job #35700
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: upodroid The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
base_ref: master | ||
path_alias: k8s.io/kubernetes | ||
- org: alaypatel07 | ||
- org: kubernetes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you please drop this, its intended to use my branch until we have merged this: kubernetes/perf-tests#3629
- org: kubernetes | ||
repo: perf-tests | ||
base_ref: dra-extended-resources | ||
base_ref: master |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you please drop this, its intended to use my branch until we have merged this: kubernetes/perf-tests#3629
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok
- name: BOSKOS_RESOURCE_TYPE | ||
value: "scalability-project" | ||
- name: KOPS_CL2_TEST_CONFIG | ||
value: testing/dra/config.yaml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need the NODE_PRELOAD_IMAGES env var for cl2 dra tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we need to preload that image? Is it too expensive to pull at runtime?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, pulling at runtime means that pod startup is breaching the 5 second SLO. More info here: https://docs.google.com/document/d/1YzPR3j0gxDNwL6iaY28trUsKVb2xyhrwHY-DqVcVaUE/edit?tab=t.0#heading=h.u5mis8uopyk2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed
value: "true" | ||
- name: PROMETHEUS_PVC_STORAGE_CLASS | ||
value: "ssd-csi" | ||
- name: CLOUD_PROVIDER |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The DRA test also require enabling certain feature flags. From the config above this is set:
- --env=KUBE_FEATURE_GATES=DynamicResourceAllocation=true
In the case of kops, should we be setting the KOPS_FEATURE_FLAGS
feature flag with above?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
DRA feature should be autoenabled already. kops does enable all GA/Beta flags by default
This is ready to be merged. I'll cancel the hold once the kops PR is merged. |
/hold
Requires kubernetes/kops#17671 to be merged first
Closes #35699
A concurrency limit is in place while the boskos-pool is growing; it will then be limited to 4.
/cc @alaypatel07 @BenTheElder @hakman
Also,
ci-kubernetes-e2e-kops-gce-100-node-dra-with-workload-ipalias-using-cl2
will replaceci-kubernetes-e2e-gce-100-node-dra-extended-resources-with-workload
once it's green.