-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replaced all references to "master" #21815
Conversation
Submitting this to PR to replace the term master on this page to Primary. I would suggest the community replace all the `master` references moving forward. #BlackLivesMatter
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Welcome @punkdata! |
"I signed it" |
Deploy preview for kubernetes-io-master-staging ready! Built with commit 215344b https://deploy-preview-21815--kubernetes-io-master-staging.netlify.app |
Ah, maybe not all references to “master”. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I recommend addressing the renaming with regard to issue #21800
* The **Kubernetes Primary** is a collection of three processes that run on a single node in your cluster, which is designated as the primary node. Those processes are: [kube-apiserver](/docs/admin/kube-apiserver/), [kube-controller-manager](/docs/admin/kube-controller-manager/) and [kube-scheduler](/docs/admin/kube-scheduler/). | ||
* Each individual non-primary node in your cluster runs two processes: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs a bit more rewording (see issue #21800): these processes don't actually have to run on a single host.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is primary the preferred term to replace master elsewhere in the docs?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is primary the preferred term to replace master elsewhere in the docs?
“It depends”. primary pairs well with replica, but sometimes it is better to replace master with control plane, or other wording (“leader” if it's the result of an election, for example).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well ... IMHO, "Kubernetes Control Plane" is the term we use elsewhere and the preferred replacement.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In other places throughout the documentation, the Master (I'll refer to this as the Primary down below) is discussed as one piece of the Kubernetes Control Plane, not a direct 1-to-1 replacement. The Kubelet is also part of the Control Plane but is not part of the Master.
If we were simply to replace the word "master" with the word "Kubernetes Control Plane", then we end up with awkward descriptions such as this at https://kubernetes.io/docs/concepts/#kubernetes-control-plane
The various parts of the Kubernetes Control Plane, such as the Kubernetes Master and kubelet processes
becomes the following, which doesn't make any sense:
The various parts of the Kubernetes Control Plane, such as the Kubernetes Control Plane and kubelet processes
We can of course re-word this to merge the Primary & CP concepts, but we need to be careful not to erase this architectural distinction. The Kubernetes documentation already has a lot of inconsistencies which are frustrating & confusing for new users. See #21755 for a similar example.
In that case, replacing "Master" with "Primary" would be the easy fix, as long the term "Primary" is the agreed-upon term and is used consistently throughout the documentation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BTW, I don't count the kubelet as part of the control plane - see for example the diagram at https://kubernetes.io/docs/concepts/overview/components/#editPageButton
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I'm going to rewrite https://kubernetes.io/docs/concepts/#kubernetes-control-plane anyway.
@punkdata Could you rebase your changes on the main branch for this repo (currently |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/assign @jimangel |
Submitting this to PR to replace the term master on this page to Primary. I would suggest the community replace all the
master
references moving forward. #BlackLivesMatter