-
Notifications
You must be signed in to change notification settings - Fork 15.1k
Add path /var/run/secrets/.../serviceaccount/token #32794
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Add path /var/run/secrets/kubernetes.io/serviceaccount/token so that new users understand the "magic".
✅ Deploy Preview for kubernetes-io-main-staging ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
/lgtm |
|
LGTM label has been added. Git tree hash: 1a9350a1c7b17a959194154c50dae3440d0bb821
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@guettli would you be willing to revise this page more thoroughly? Every mention of “version 1.6+” is now stale because version 1.5 and older of Kubernetes are very much not supported any more.
content/en/docs/tasks/configure-pod-container/configure-service-account.md
Outdated
Show resolved
Hide resolved
…e-account.md Co-authored-by: Tim Bannister <[email protected]>
|
/label tide/merge-method-squash |
That would definitely be a valuable update. That said, I'd rather approve a single incremental improvement and invite others to follow. /lgtm |
|
LGTM label has been added. Git tree hash: ee9838d633ed57589f782fcf0a7cd4eebb3d7e65
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: zacharysarah The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Add path /var/run/secrets/kubernetes.io/serviceaccount/token so that new users understand the "magic".