Skip to content

Conversation

@guettli
Copy link
Contributor

@guettli guettli commented Apr 7, 2022

Add path /var/run/secrets/kubernetes.io/serviceaccount/token so that new users understand the "magic".

Add path /var/run/secrets/kubernetes.io/serviceaccount/token so that new users understand the "magic".
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 7, 2022
@k8s-ci-robot k8s-ci-robot requested review from liggitt and thockin April 7, 2022 06:27
@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Apr 7, 2022
@netlify
Copy link

netlify bot commented Apr 7, 2022

Deploy Preview for kubernetes-io-main-staging ready!

Name Link
🔨 Latest commit 7ce5c2b
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/6255d43dad3c4c0008c13e70
😎 Deploy Preview https://deploy-preview-32794--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@tengqm
Copy link
Contributor

tengqm commented Apr 8, 2022

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 8, 2022
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 1a9350a1c7b17a959194154c50dae3440d0bb821

Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@guettli would you be willing to revise this page more thoroughly? Every mention of “version 1.6+” is now stale because version 1.5 and older of Kubernetes are very much not supported any more.

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 12, 2022
@k8s-ci-robot k8s-ci-robot requested a review from tengqm April 12, 2022 19:34
@tengqm
Copy link
Contributor

tengqm commented Apr 13, 2022

/label tide/merge-method-squash

@k8s-ci-robot k8s-ci-robot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Apr 13, 2022
@zacharysarah
Copy link
Contributor

@guettli would you be willing to revise this page more thoroughly? Every mention of “version 1.6+” is now stale because version 1.5 and older of Kubernetes are very much not supported any more.

That would definitely be a valuable update. That said, I'd rather approve a single incremental improvement and invite others to follow.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 14, 2022
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: ee9838d633ed57589f782fcf0a7cd4eebb3d7e65

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zacharysarah

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 14, 2022
@k8s-ci-robot k8s-ci-robot merged commit a170f56 into kubernetes:main Jun 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants