Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[de] sync content/de/docs/concepts/_index.md from upstream #33406

Closed
wants to merge 1 commit into from
Closed

[de] sync content/de/docs/concepts/_index.md from upstream #33406

wants to merge 1 commit into from

Conversation

JarHMJ
Copy link
Member

@JarHMJ JarHMJ commented May 2, 2022

No description provided.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 2, 2022
@k8s-ci-robot k8s-ci-robot requested review from bene2k1 and mkorbi May 2, 2022 14:49
@k8s-ci-robot k8s-ci-robot added language/de Issues or PRs related to German language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels May 2, 2022
@netlify
Copy link

netlify bot commented May 2, 2022

✅ Deploy Preview for kubernetes-io-main-staging ready!

Name Link
🔨 Latest commit 4412d13
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/626fef5ec2943a0008b8bf5a
😎 Deploy Preview https://deploy-preview-33406--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

sftim
sftim reviewed May 2, 2022
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bene2k1
Copy link
Member

bene2k1 commented May 3, 2022

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bene2k1

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 3, 2022
@JarHMJ JarHMJ requested a review from sftim May 4, 2022 13:43
@JarHMJ
Copy link
Member Author

JarHMJ commented May 5, 2022

please review @sftim

@sftim
Copy link
Contributor

sftim commented May 5, 2022

That's an informal LGTM. I'm not a reviewer for the German localization.

@Sea-n
Copy link
Member

Sea-n commented Jul 2, 2022

Those contents are not "removed". It's rewritten to each page, please refer to PR #21997.

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 2, 2022
@Sea-n
Copy link
Member

Sea-n commented Jul 22, 2022

Hey @JarHMJ,

It's been a while since last update, would you like to sync the rewritten article so that we can move forward?

@JarHMJ
Copy link
Member Author

JarHMJ commented Jul 22, 2022

Hey @JarHMJ,

It's been a while since last update, would you like to sync the rewritten article so that we can move forward?

Sorry. I can't translate German, maybe someone else can.

@JarHMJ JarHMJ closed this Jul 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bene2k1 bene2k1 Awaiting requested review from bene2k1

@mkorbi mkorbi Awaiting requested review from mkorbi

@sftim sftim Awaiting requested review from sftim

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. language/de Issues or PRs related to German language sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@JarHMJ @bene2k1 @k8s-ci-robot @sftim @Sea-n