chore: resolve comments

kubeshop · Jun 20, 2023 · c87a541 · c87a541
1 parent fdb883b
commit c87a541
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 2 deletions.
diff --git a/src/components/organisms/CreateProjectModal/CreateProjectModal.tsx b/src/components/organisms/CreateProjectModal/CreateProjectModal.tsx
@@ -49,7 +49,6 @@ const CreateProjectModal: React.FC = () => {
         dispatch(setCreateProject({name, rootFolder}));
         onCloseModalHandler();
       } else {
-        trackEvent('app_start/create_project', {from: 'folder'});
         dispatch(setTemplateProjectCreate({name, rootFolder}));
         dispatch(openTemplateExplorer());
         onCloseModalHandler();

diff --git a/src/components/organisms/NewProject/NewProject.tsx b/src/components/organisms/NewProject/NewProject.tsx
@@ -106,6 +106,7 @@ const NewProject: React.FC = () => {
       itemDescription: 'Create a new project from a Helm Chart in a Helm repository, and save it locally.',
       itemAction: () => {
         dispatch(openHelmRepoModal());
+        trackEvent('app_start/create_project', {from: 'helm'});
       },
     },
   ];

diff --git a/src/redux/thunks/project/createProject.ts b/src/redux/thunks/project/createProject.ts
@@ -4,6 +4,7 @@ import {createProject} from '@redux/appConfig';
 import {isFolderGitRepo} from '@redux/git/git.ipc';
 
 import {Project} from '@shared/models/config';
+import {trackEvent} from '@shared/utils/telemetry';
 
 import {setOpenProject} from './openProject';
 
@@ -18,4 +19,5 @@ export const setCreateProject = createAsyncThunk('config/setCreateProject', asyn
 
   thunkAPI.dispatch(createProject({...project, isGitRepo}));
   thunkAPI.dispatch(setOpenProject(project.rootFolder));
+  trackEvent('app_start/create_project', {from: 'folder'});
 });
diff --git a/src/shared/models/telemetry.ts b/src/shared/models/telemetry.ts
@@ -46,7 +46,10 @@ export type EventMap = {
     numberOfValuesFiles: number;
     executionTime: number;
   };
-  'app_start/create_project': {from: 'sample' | 'scratch' | 'git' | 'template' | 'folder'; templateID?: string};
+  'app_start/create_project': {
+    from: 'sample' | 'scratch' | 'git' | 'template' | 'folder' | 'helm';
+    templateID?: string;
+  };
   'app_start/select_page': {page: string};
   'app_start/select_project': undefined;
   'project_list/open_project': undefined;