Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update minio image tag; nats imagePullSecrets #235

Merged
merged 8 commits into from
Nov 15, 2024

Conversation

ypoplavs
Copy link
Collaborator

Checklist:

  • Any new values are backwards compatible and/or have sensible default.
  • I have signed off all my commits as required by DCO.
  • My CI is green.

@ypoplavs ypoplavs marked this pull request as ready for review November 14, 2024 16:18
@ypoplavs ypoplavs requested a review from a team as a code owner November 14, 2024 16:18
{{- end }}
{{- end }}
{{- range . }}
{{- if typeIs "slice" . }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the case of the slice so supposed to handle? You are ranging here so the . is referring to the entity in the list, something like this?

imagePullSecrets:
  - ['secret1', 'secret2']

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

slice not needed, remnants of some testing which were overlooked, I have removed it

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now it's supposed to handle cases like:

imagePullSecrets:
   - name: secret1
   - name: secret2
 
imagePullSecrets:
   - secret1
   - secret2

imagePullSecrets: ['secret1', 'secret2']

But testkube-enterprise chart for now accepts only first option. I guess for the majority of our services we need to make modifications to accept different types. I'll add this to the docs.

@ypoplavs ypoplavs merged commit ee35f84 into main Nov 15, 2024
5 checks passed
@ypoplavs ypoplavs deleted the sandbox/update-minio-image-tag branch November 15, 2024 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants