-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: update minio image tag; nats imagePullSecrets #235
Conversation
{{- end }} | ||
{{- end }} | ||
{{- range . }} | ||
{{- if typeIs "slice" . }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the case of the slice so supposed to handle? You are ranging here so the .
is referring to the entity in the list, something like this?
imagePullSecrets:
- ['secret1', 'secret2']
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
slice not needed, remnants of some testing which were overlooked, I have removed it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now it's supposed to handle cases like:
imagePullSecrets:
- name: secret1
- name: secret2
imagePullSecrets:
- secret1
- secret2
imagePullSecrets: ['secret1', 'secret2']
But testkube-enterprise chart for now accepts only first option. I guess for the majority of our services we need to make modifications to accept different types. I'll add this to the docs.
Checklist: