Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update oidc-Identity-provider.md #343

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

wansir
Copy link
Member

@wansir wansir commented May 25, 2021

Signed-off-by: hongming [email protected]

@ks-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wansir

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ks-ci-bot ks-ci-bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 25, 2021
@@ -26,7 +26,7 @@ data:
clientID: '********'
clientSecret: '********'
issuer: https://accounts.google.com
redirectURL: 'http://ks-console/oauth/redirect'
redirectURL: 'http://ks-console/oauth/redirect/google'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be great if you could provide some references here. For example, document, code line. Because I don't familiar with the feature. I cannot determine if it's correct.

@yangchuansheng yangchuansheng force-pushed the master branch 4 times, most recently from 4a41274 to a30f1e3 Compare November 29, 2022 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants