Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: abnormal port occupation #4489

Open
wants to merge 1 commit into
base: release-4.1
Choose a base branch
from
Open

fix: abnormal port occupation #4489

wants to merge 1 commit into from

Conversation

Jun1911
Copy link

@Jun1911 Jun1911 commented Feb 24, 2025

What type of PR is this?

/kind bug

What this PR does / why we need it

Solved the problem of port occupation that occasionally occurred in the development environment, reducing the debugging time of the development environment

Which issue(s) this PR fixes

Links: kubesphere/kubesphere#6372

Special notes for reviewers

None

Does this PR introduced a user-facing change?

None

Additional documentation, usage docs, etc

None

fix: abnormal port occupation
681292b 
* feat: optimize webpack's localhost output display
* fix: added a fallback logic for shutting down services

Signed-off-by: wanyijun <[email protected]>
@ks-ci-bot ks-ci-bot added release-note-none kind/bug Categorizes issue or PR as related to a bug. labels Feb 24, 2025
@ks-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Jun1911
To complete the pull request process, please assign donniean after the PR has been reviewed.
You can assign the PR to them by writing /assign @donniean in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ks-ci-bot ks-ci-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 24, 2025
@donniean
Copy link
Contributor

/cc @yazhouio

@ks-ci-bot ks-ci-bot requested a review from yazhouio February 24, 2025 03:02
@donniean
Copy link
Contributor

/cherry-pick master

@ks-ci-bot
Copy link
Collaborator

@donniean: once the present PR merges, I will cherry-pick it on top of master in a new PR and assign it to you.

In response to this:

/cherry-pick master

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@donniean
Copy link
Contributor

/hold

donniean
donniean requested changes Feb 25, 2025
View reviewed changes
server/server.js
}, 5000);
};

// Capture Ctrl+C
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a condition to take effect only in the development environment

@donniean
Copy link
Contributor

/hold

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@donniean donniean donniean requested changes

@yazhouio yazhouio Awaiting requested review from yazhouio

Assignees
No one assigned
Labels
do-not-merge/hold kind/bug Categorizes issue or PR as related to a bug. release-note-none size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Jun1911 @ks-ci-bot @donniean