Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MTV-1609 | VM source templates should not be selectable in the VM table #1379

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Hazanel
Copy link

@Hazanel Hazanel commented Feb 26, 2025

Issue:
VM source templates should not be selectable in the VM table

Fix:
Filter the resources list with only non templates VM sources

@codecov-commenter
Copy link

codecov-commenter commented Feb 26, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 12 lines in your changes missing coverage. Please review.

Project coverage is 15.46%. Comparing base (f1fe5d0) to head (b9b0bb8).
Report is 28 commits behind head on main.

Files with missing lines Patch % Lines
pkg/controller/provider/web/vsphere/vm.go 0.00% 12 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff            @@
##             main    #1379    +/-   ##
========================================
  Coverage   15.45%   15.46%            
========================================
  Files         112      112            
  Lines       23377    23777   +400     
========================================
+ Hits         3613     3676    +63     
- Misses      19479    19817   +338     
+ Partials      285      284     -1     
Flag Coverage Δ
unittests 15.46% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mnecas mnecas changed the title MTV- 1609 | VM source templates should not be selectable in the VM table MTV-1609 | VM source templates should not be selectable in the VM table Feb 28, 2025
    Issue:
    VM source templates should not be selectable in the VM table

    Fix:
    Filter the resources list with only non templates VM sources

Signed-off-by: ehazan <[email protected]>
Copy link

sonarqubecloud bot commented Mar 2, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants