-
Notifications
You must be signed in to change notification settings - Fork 209
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request #1336 from kanchan-dhamane/update-contributor-guide
Chore: Add note for make reviewable in Prerequisites section of Code Contrib…
- Loading branch information
Showing
4 changed files
with
16 additions
and
4 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -128,6 +128,9 @@ For other OS or system architecture, please refer to https://storage.googleapis. | |
| go install sigs.k8s.io/controller-tools/cmd/[email protected] | ||
| go install golang.org/x/tools/cmd/goimports@latest | ||
| ``` | ||
| :::caution | ||
| Note: For macOS, you may need to install [diffutils](https://www.gnu.org/software/diffutils/). | ||
| ::: | ||
|
|
||
| :::tip | ||
| You may also be interested with KubeVela's [design](https://github.com/oam-dev/kubevela/tree/master/design/vela-core) before diving into its code. | ||
|
|
@@ -493,4 +496,4 @@ To solve this issue, execute: | |
| ```bash | ||
| go install golang.org/x/tools/cmd/goimports@latest | ||
| ``` | ||
| ``` | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -127,6 +127,9 @@ For other OS or system architecture, please refer to https://storage.googleapis. | |
| go install sigs.k8s.io/controller-tools/cmd/[email protected] | ||
| go install golang.org/x/tools/cmd/goimports@latest | ||
| ``` | ||
| :::caution | ||
| Note: For macOS, you may need to install [diffutils](https://www.gnu.org/software/diffutils/). | ||
| ::: | ||
|
|
||
| :::tip | ||
| You may also be interested with KubeVela's [design](https://github.com/oam-dev/kubevela/tree/master/design/vela-core) before diving into its code. | ||
|
|
@@ -471,4 +474,4 @@ Learn how to write the docs by the following guide: | |
| * [kubevela.io Developer Guide](https://github.com/kubevela/kubevela.io/blob/main/README.md) | ||
| * [Update KubeVela.io CLI Reference Doc](./cli-ref-doc.md) | ||
|
|
||
| Great, you have complete the lifecycle of code contribution, try to [join the community as a member](https://github.com/kubevela/community/blob/main/community-membership.md) if you're interested. | ||
| Great, you have complete the lifecycle of code contribution, try to [join the community as a member](https://github.com/kubevela/community/blob/main/community-membership.md) if you're interested. | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -127,6 +127,9 @@ For other OS or system architecture, please refer to https://storage.googleapis. | |
| go install sigs.k8s.io/controller-tools/cmd/[email protected] | ||
| go install golang.org/x/tools/cmd/goimports@latest | ||
| ``` | ||
| :::caution | ||
| Note: For macOS, you may need to install [diffutils](https://www.gnu.org/software/diffutils/). | ||
| ::: | ||
|
|
||
| :::tip | ||
| You may also be interested with KubeVela's [design](https://github.com/oam-dev/kubevela/tree/master/design/vela-core) before diving into its code. | ||
|
|
@@ -471,4 +474,4 @@ Learn how to write the docs by the following guide: | |
| * [kubevela.io Developer Guide](https://github.com/kubevela/kubevela.io/blob/main/README.md) | ||
| * [Update KubeVela.io CLI Reference Doc](./cli-ref-doc.md) | ||
|
|
||
| Great, you have complete the lifecycle of code contribution, try to [join the community as a member](https://github.com/kubevela/community/blob/main/community-membership.md) if you're interested. | ||
| Great, you have complete the lifecycle of code contribution, try to [join the community as a member](https://github.com/kubevela/community/blob/main/community-membership.md) if you're interested. | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -128,6 +128,9 @@ For other OS or system architecture, please refer to https://storage.googleapis. | |
| go install sigs.k8s.io/controller-tools/cmd/[email protected] | ||
| go install golang.org/x/tools/cmd/goimports@latest | ||
| ``` | ||
| :::caution | ||
| Note: For macOS, you may need to install [diffutils](https://www.gnu.org/software/diffutils/). | ||
| ::: | ||
|
|
||
| :::tip | ||
| You may also be interested with KubeVela's [design](https://github.com/oam-dev/kubevela/tree/master/design/vela-core) before diving into its code. | ||
|
|
@@ -493,4 +496,4 @@ To solve this issue, execute: | |
| ```bash | ||
| go install golang.org/x/tools/cmd/goimports@latest | ||
| ``` | ||
| ``` | ||