Skip to content

Fix: Updates the addon-operation WFS to newer image and corrects wait… #210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

briankane
Copy link
Contributor

@briankane briankane commented Jun 11, 2025

… logic

Description of your changes

  1. Fixes issues with addon-operation not waiting for correct status reporting of the created Job (always showing as failed despite the addon succeeding).
  2. Updates the image in use (latest version) as step fails with the current image.

Fixes #

  1. Addon-Operation - WFR Status Always Shows Failed #207
  2. Addon-Operation Default Image - Pods Fail #208

I have:

  • Read and followed KubeVela's contribution process.
  • [] ~~Related Docs updated properly. In a new feature or configuration option, an update to the documentation is necessary. ~~
  • Run make reviewable to ensure this PR is ready for review.
  • Added backport release-x.y labels to auto-backport this PR if necessary.

How has this code been tested

  • Reproduced issues locally with existing workflow step.
  • Deployed updated workstep step.
  • Confirmed addons are now created as expected and the WorkflowRun & Step correctly reflect the successful installation of the addon.

Special notes for your reviewer

N/A


Summary by cubic

Updated the addon-operation workflow step to use the latest image and fixed the wait logic so job status is reported correctly.

  • Bug Fixes

    • Fixed issue where the step always showed as failed even when the addon succeeded.
    • Improved wait logic to check both succeeded and failed job statuses.
  • Dependencies

    • Updated the default image to oamdev/vela-cli:v1.10.3.

Copy link

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cubic reviewed this PR and found no issues. Review PR in cubic.dev.

@briankane briankane force-pushed the fix/addon-operation-workflowstep-fixes branch from d471114 to 9dae36f Compare June 11, 2025 07:33
@briankane briankane force-pushed the fix/addon-operation-workflowstep-fixes branch from 9dae36f to 7029070 Compare June 11, 2025 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant