badges: Add percentage of no retests to the No Retests badge #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Brian Carey <[email protected]>
kubevirt-bot
added
dco-signoff: yes
dhiller
approved these changes
Dec 12, 2024
| @@ -259,7 +259,7 @@ func (d *RunningAverageDataItem) String() string { | |||
| } | |||
|
|
|||
| func (d *RunningAverageDataItem) SimpleBadgeString() string { | |||
| return fmt.Sprintf(constants.NoRetestBadgeDataFormat, d.NoRetest, d.Number) | |||
| return fmt.Sprintf(constants.NoRetestBadgeDataFormat, d.NoRetest, d.Number, (d.NoRetest/d.Number)*100, "%") | |||
There was a problem hiding this comment.
nit: if d.Number is zero this will do a NaN, but I don't think it will harm
There was a problem hiding this comment.
if we have no PRs merged in 7 days we will have bigger problems 😆
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Rather than leaving the user calculate the percentage of No Retests - lets add it to the badge
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
/cc @dhiller
Checklist
This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.
Release note: