Skip to content

Commit

Permalink
fix: verification of the python openshift requirement
Browse files Browse the repository at this point in the history
The unit-tests.sh script may fail at an advanced stage if the
python openShift module is not installed. Failing at the initial
step alerts the user to this requirement.

Signed-off-by: Nestor Acuna Blanco <[email protected]>
  • Loading branch information
nestoracunablanco committed Jul 31, 2024
1 parent 73c6fa0 commit e74173f
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 1 deletion.
3 changes: 3 additions & 0 deletions automation/unit-tests.sh
Original file line number Diff line number Diff line change
@@ -1,6 +1,9 @@
#!/bin/bash
set -ex

# dependency check
pip show -q openshift

#syntax check
templates=$(ls dist/templates/*)
namespace="kubevirt"
Expand Down
2 changes: 1 addition & 1 deletion builder/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
FROM quay.io/fedora/fedora:latest

# Install dependencies and tools
RUN dnf install -y jq ansible python3-gobject python3-openshift libosinfo intltool make git findutils expect golang podman
RUN dnf install -y jq ansible python3-gobject python3-openshift python3-pip libosinfo intltool make git findutils expect golang podman

# Allow writes to /etc/passwd so a user for ansible can be added by CI commands
RUN chmod a+w /etc/passwd
Expand Down

0 comments on commit e74173f

Please sign in to comment.