Change default value for completionTimeoutPerGiB to 150s

api/v1beta1/hyperconverged_types.go

@@ -72,7 +72,7 @@ type HyperConvergedSpec struct {
 
 	// Live migration limits and timeouts are applied so that migration processes do not
 	// overwhelm the cluster.
-	// +kubebuilder:default={"completionTimeoutPerGiB": 800, "parallelMigrationsPerCluster": 5, "parallelOutboundMigrationsPerNode": 2, "progressTimeout": 150, "allowAutoConverge": false, "allowPostCopy": false}
+	// +kubebuilder:default={"completionTimeoutPerGiB": 150, "parallelMigrationsPerCluster": 5, "parallelOutboundMigrationsPerNode": 2, "progressTimeout": 150, "allowAutoConverge": false, "allowPostCopy": false}
 	// +optional
 	LiveMigrationConfig LiveMigrationConfigurations `json:"liveMigrationConfig,omitempty"`
 
@@ -337,8 +337,8 @@ type LiveMigrationConfigurations struct {
 	// higher completionTimeoutPerGiB to let workload with spikes in its memory dirty
 	// rate to converge.
 	// The format is a number.
-	// +kubebuilder:default=800
-	// +default=800
+	// +kubebuilder:default=150
+	// +default=150
 	// +optional
 	CompletionTimeoutPerGiB *int64 `json:"completionTimeoutPerGiB,omitempty"`
 
@@ -844,7 +844,7 @@ type HyperConverged struct {
 	metav1.TypeMeta   `json:",inline"`
 	metav1.ObjectMeta `json:"metadata,omitempty"`
 
-	// +kubebuilder:default={"certConfig": {"ca": {"duration": "48h0m0s", "renewBefore": "24h0m0s"}, "server": {"duration": "24h0m0s", "renewBefore": "12h0m0s"}},"featureGates": {"downwardMetrics": false, "enableCommonBootImageImport": true, "deployVmConsoleProxy": false, "deployKubeSecondaryDNS": false, "disableMDevConfiguration": false, "persistentReservation": false, "autoResourceLimits": false, "enableApplicationAwareQuota": false, "primaryUserDefinedNetworkBinding": false}, "liveMigrationConfig": {"completionTimeoutPerGiB": 800, "parallelMigrationsPerCluster": 5, "parallelOutboundMigrationsPerNode": 2, "progressTimeout": 150, "allowAutoConverge": false, "allowPostCopy": false}, "resourceRequirements": {"vmiCPUAllocationRatio": 10}, "uninstallStrategy": "BlockUninstallIfWorkloadsExist", "virtualMachineOptions": {"disableFreePageReporting": false, "disableSerialConsoleLog": true}}
+	// +kubebuilder:default={"certConfig": {"ca": {"duration": "48h0m0s", "renewBefore": "24h0m0s"}, "server": {"duration": "24h0m0s", "renewBefore": "12h0m0s"}},"featureGates": {"downwardMetrics": false, "enableCommonBootImageImport": true, "deployVmConsoleProxy": false, "deployKubeSecondaryDNS": false, "disableMDevConfiguration": false, "persistentReservation": false, "autoResourceLimits": false, "enableApplicationAwareQuota": false, "primaryUserDefinedNetworkBinding": false}, "liveMigrationConfig": {"completionTimeoutPerGiB": 150, "parallelMigrationsPerCluster": 5, "parallelOutboundMigrationsPerNode": 2, "progressTimeout": 150, "allowAutoConverge": false, "allowPostCopy": false}, "resourceRequirements": {"vmiCPUAllocationRatio": 10}, "uninstallStrategy": "BlockUninstallIfWorkloadsExist", "virtualMachineOptions": {"disableFreePageReporting": false, "disableSerialConsoleLog": true}}
 	// +optional
 	Spec   HyperConvergedSpec   `json:"spec,omitempty"`
 	Status HyperConvergedStatus `json:"status,omitempty"`

config/crd/bases/hco.kubevirt.io_hyperconvergeds.yaml

@@ -69,7 +69,7 @@ spec:
               liveMigrationConfig:
                 allowAutoConverge: false
                 allowPostCopy: false
-                completionTimeoutPerGiB: 800
+                completionTimeoutPerGiB: 150
                 parallelMigrationsPerCluster: 5
                 parallelOutboundMigrationsPerNode: 2
                 progressTimeout: 150
@@ -2224,7 +2224,7 @@ spec:
                 default:
                   allowAutoConverge: false
                   allowPostCopy: false
-                  completionTimeoutPerGiB: 800
+                  completionTimeoutPerGiB: 150
                   parallelMigrationsPerCluster: 5
                   parallelOutboundMigrationsPerNode: 2
                   progressTimeout: 150
@@ -2256,7 +2256,7 @@ spec:
                     pattern: ^(\+|-)?(([0-9]+(\.[0-9]*)?)|(\.[0-9]+))(([KMGTPE]i)|[numkMGTPE]|([eE](\+|-)?(([0-9]+(\.[0-9]*)?)|(\.[0-9]+))))?$
                     type: string
                   completionTimeoutPerGiB:
-                    default: 800
+                    default: 150
                     description: |-
                       If a migrating VM is big and busy, while the connection to the destination node
                       is slow, migration may never converge. The completion timeout is calculated

controllers/operands/kubevirt_test.go

@@ -335,7 +335,7 @@ Version: 1.2.3`)
 			mc := foundResource.Spec.Configuration.MigrationConfiguration
 			Expect(mc).ToNot(BeNil())
 			Expect(mc.BandwidthPerMigration).To(BeNil())
-			Expect(*mc.CompletionTimeoutPerGiB).To(Equal(int64(800)))
+			Expect(*mc.CompletionTimeoutPerGiB).To(Equal(int64(150)))
 			Expect(*mc.ParallelMigrationsPerCluster).To(Equal(uint32(5)))
 			Expect(*mc.ParallelOutboundMigrationsPerNode).To(Equal(uint32(2)))
 			Expect(*mc.ProgressTimeout).To(Equal(int64(150)))
@@ -544,7 +544,7 @@ Version: 1.2.3`)
 			mc := foundResource.Spec.Configuration.MigrationConfiguration
 			Expect(mc).ToNot(BeNil())
 			Expect(mc.BandwidthPerMigration).To(BeNil())
-			Expect(*mc.CompletionTimeoutPerGiB).To(Equal(int64(800)))
+			Expect(*mc.CompletionTimeoutPerGiB).To(Equal(int64(150)))
 			Expect(*mc.ParallelMigrationsPerCluster).To(Equal(uint32(5)))
 			Expect(*mc.ParallelOutboundMigrationsPerNode).To(Equal(uint32(2)))
 			Expect(*mc.ProgressTimeout).To(Equal(int64(150)))

deploy/crds/hco00.crd.yaml

@@ -69,7 +69,7 @@ spec:
               liveMigrationConfig:
                 allowAutoConverge: false
                 allowPostCopy: false
-                completionTimeoutPerGiB: 800
+                completionTimeoutPerGiB: 150
                 parallelMigrationsPerCluster: 5
                 parallelOutboundMigrationsPerNode: 2
                 progressTimeout: 150
@@ -2224,7 +2224,7 @@ spec:
                 default:
                   allowAutoConverge: false
                   allowPostCopy: false
-                  completionTimeoutPerGiB: 800
+                  completionTimeoutPerGiB: 150
                   parallelMigrationsPerCluster: 5
                   parallelOutboundMigrationsPerNode: 2
                   progressTimeout: 150
@@ -2256,7 +2256,7 @@ spec:
                     pattern: ^(\+|-)?(([0-9]+(\.[0-9]*)?)|(\.[0-9]+))(([KMGTPE]i)|[numkMGTPE]|([eE](\+|-)?(([0-9]+(\.[0-9]*)?)|(\.[0-9]+))))?$
                     type: string
                   completionTimeoutPerGiB:
-                    default: 800
+                    default: 150
                     description: |-
                       If a migrating VM is big and busy, while the connection to the destination node
                       is slow, migration may never converge. The completion timeout is calculated

deploy/hco.cr.yaml

@@ -28,7 +28,7 @@ spec:
   liveMigrationConfig:
     allowAutoConverge: false
     allowPostCopy: false
-    completionTimeoutPerGiB: 800
+    completionTimeoutPerGiB: 150
     parallelMigrationsPerCluster: 5
     parallelOutboundMigrationsPerNode: 2
     progressTimeout: 150

deploy/index-image/community-kubevirt-hyperconverged/1.14.0/manifests/hco00.crd.yaml

@@ -69,7 +69,7 @@ spec:
               liveMigrationConfig:
                 allowAutoConverge: false
                 allowPostCopy: false
-                completionTimeoutPerGiB: 800
+                completionTimeoutPerGiB: 150
                 parallelMigrationsPerCluster: 5
                 parallelOutboundMigrationsPerNode: 2
                 progressTimeout: 150
@@ -2224,7 +2224,7 @@ spec:
                 default:
                   allowAutoConverge: false
                   allowPostCopy: false
-                  completionTimeoutPerGiB: 800
+                  completionTimeoutPerGiB: 150
                   parallelMigrationsPerCluster: 5
                   parallelOutboundMigrationsPerNode: 2
                   progressTimeout: 150
@@ -2256,7 +2256,7 @@ spec:
                     pattern: ^(\+|-)?(([0-9]+(\.[0-9]*)?)|(\.[0-9]+))(([KMGTPE]i)|[numkMGTPE]|([eE](\+|-)?(([0-9]+(\.[0-9]*)?)|(\.[0-9]+))))?$
                     type: string
                   completionTimeoutPerGiB:
-                    default: 800
+                    default: 150
                     description: |-
                       If a migrating VM is big and busy, while the connection to the destination node
                       is slow, migration may never converge. The completion timeout is calculated

deploy/olm-catalog/community-kubevirt-hyperconverged/1.14.0/manifests/hco00.crd.yaml

@@ -69,7 +69,7 @@ spec:
               liveMigrationConfig:
                 allowAutoConverge: false
                 allowPostCopy: false
-                completionTimeoutPerGiB: 800
+                completionTimeoutPerGiB: 150
                 parallelMigrationsPerCluster: 5
                 parallelOutboundMigrationsPerNode: 2
                 progressTimeout: 150
@@ -2224,7 +2224,7 @@ spec:
                 default:
                   allowAutoConverge: false
                   allowPostCopy: false
-                  completionTimeoutPerGiB: 800
+                  completionTimeoutPerGiB: 150
                   parallelMigrationsPerCluster: 5
                   parallelOutboundMigrationsPerNode: 2
                   progressTimeout: 150
@@ -2256,7 +2256,7 @@ spec:
                     pattern: ^(\+|-)?(([0-9]+(\.[0-9]*)?)|(\.[0-9]+))(([KMGTPE]i)|[numkMGTPE]|([eE](\+|-)?(([0-9]+(\.[0-9]*)?)|(\.[0-9]+))))?$
                     type: string
                   completionTimeoutPerGiB:
-                    default: 800
+                    default: 150
                     description: |-
                       If a migrating VM is big and busy, while the connection to the destination node
                       is slow, migration may never converge. The completion timeout is calculated

docs/api.md

@@ -121,7 +121,7 @@ HyperConverged is the Schema for the hyperconvergeds API
 | Field | Description | Scheme | Default | Required |
 | ----- | ----------- | ------ | -------- |-------- |
 | metadata |  | [metav1.ObjectMeta](https://kubernetes.io/docs/reference/generated/kubernetes-api/v1.17/#objectmeta-v1-meta) |  | false |
-| spec |  | [HyperConvergedSpec](#hyperconvergedspec) | {"certConfig": {"ca": {"duration": "48h0m0s", "renewBefore": "24h0m0s"}, "server": {"duration": "24h0m0s", "renewBefore": "12h0m0s"}},"featureGates": {"downwardMetrics": false, "enableCommonBootImageImport": true, "deployVmConsoleProxy": false, "deployKubeSecondaryDNS": false, "disableMDevConfiguration": false, "persistentReservation": false, "autoResourceLimits": false, "enableApplicationAwareQuota": false, "primaryUserDefinedNetworkBinding": false}, "liveMigrationConfig": {"completionTimeoutPerGiB": 800, "parallelMigrationsPerCluster": 5, "parallelOutboundMigrationsPerNode": 2, "progressTimeout": 150, "allowAutoConverge": false, "allowPostCopy": false}, "resourceRequirements": {"vmiCPUAllocationRatio": 10}, "uninstallStrategy": "BlockUninstallIfWorkloadsExist", "virtualMachineOptions": {"disableFreePageReporting": false, "disableSerialConsoleLog": true}} | false |
+| spec |  | [HyperConvergedSpec](#hyperconvergedspec) | {"certConfig": {"ca": {"duration": "48h0m0s", "renewBefore": "24h0m0s"}, "server": {"duration": "24h0m0s", "renewBefore": "12h0m0s"}},"featureGates": {"downwardMetrics": false, "enableCommonBootImageImport": true, "deployVmConsoleProxy": false, "deployKubeSecondaryDNS": false, "disableMDevConfiguration": false, "persistentReservation": false, "autoResourceLimits": false, "enableApplicationAwareQuota": false, "primaryUserDefinedNetworkBinding": false}, "liveMigrationConfig": {"completionTimeoutPerGiB": 150, "parallelMigrationsPerCluster": 5, "parallelOutboundMigrationsPerNode": 2, "progressTimeout": 150, "allowAutoConverge": false, "allowPostCopy": false}, "resourceRequirements": {"vmiCPUAllocationRatio": 10}, "uninstallStrategy": "BlockUninstallIfWorkloadsExist", "virtualMachineOptions": {"disableFreePageReporting": false, "disableSerialConsoleLog": true}} | false |
 | status |  | [HyperConvergedStatus](#hyperconvergedstatus) |  | false |
 
 [Back to TOC](#table-of-contents)
@@ -201,7 +201,7 @@ HyperConvergedSpec defines the desired state of HyperConverged
 | infra | infra HyperConvergedConfig influences the pod configuration (currently only placement) for all the infra components needed on the virtualization enabled cluster but not necessarily directly on each node running VMs/VMIs. | [HyperConvergedConfig](#hyperconvergedconfig) |  | false |
 | workloads | workloads HyperConvergedConfig influences the pod configuration (currently only placement) of components which need to be running on a node where virtualization workloads should be able to run. Changes to Workloads HyperConvergedConfig can be applied only without existing workload. | [HyperConvergedConfig](#hyperconvergedconfig) |  | false |
 | featureGates | featureGates is a map of feature gate flags. Setting a flag to `true` will enable the feature. Setting `false` or removing the feature gate, disables the feature. | [HyperConvergedFeatureGates](#hyperconvergedfeaturegates) | {"downwardMetrics": false, "enableCommonBootImageImport": true, "deployVmConsoleProxy": false, "deployKubeSecondaryDNS": false, "disableMDevConfiguration": false, "persistentReservation": false, "autoResourceLimits": false, "enableApplicationAwareQuota": false, "primaryUserDefinedNetworkBinding": false} | false |
-| liveMigrationConfig | Live migration limits and timeouts are applied so that migration processes do not overwhelm the cluster. | [LiveMigrationConfigurations](#livemigrationconfigurations) | {"completionTimeoutPerGiB": 800, "parallelMigrationsPerCluster": 5, "parallelOutboundMigrationsPerNode": 2, "progressTimeout": 150, "allowAutoConverge": false, "allowPostCopy": false} | false |
+| liveMigrationConfig | Live migration limits and timeouts are applied so that migration processes do not overwhelm the cluster. | [LiveMigrationConfigurations](#livemigrationconfigurations) | {"completionTimeoutPerGiB": 150, "parallelMigrationsPerCluster": 5, "parallelOutboundMigrationsPerNode": 2, "progressTimeout": 150, "allowAutoConverge": false, "allowPostCopy": false} | false |
 | permittedHostDevices | PermittedHostDevices holds information about devices allowed for passthrough | *[PermittedHostDevices](#permittedhostdevices) |  | false |
 | mediatedDevicesConfiguration | MediatedDevicesConfiguration holds information about MDEV types to be defined on nodes, if available | *[MediatedDevicesConfiguration](#mediateddevicesconfiguration) |  | false |
 | certConfig | certConfig holds the rotation policy for internal, self-signed certificates | [HyperConvergedCertConfig](#hyperconvergedcertconfig) | {"ca": {"duration": "48h0m0s", "renewBefore": "24h0m0s"}, "server": {"duration": "24h0m0s", "renewBefore": "12h0m0s"}} | false |
@@ -271,7 +271,7 @@ LiveMigrationConfigurations - Live migration limits and timeouts are applied so
 | parallelMigrationsPerCluster | Number of migrations running in parallel in the cluster. | *uint32 | 5 | false |
 | parallelOutboundMigrationsPerNode | Maximum number of outbound migrations per node. | *uint32 | 2 | false |
 | bandwidthPerMigration | Bandwidth limit of each migration, the value is quantity of bytes per second (e.g. 2048Mi = 2048MiB/sec) | *string |  | false |
-| completionTimeoutPerGiB | If a migrating VM is big and busy, while the connection to the destination node is slow, migration may never converge. The completion timeout is calculated based on completionTimeoutPerGiB times the size of the guest (both RAM and migrated disks, if any). For example, with completionTimeoutPerGiB set to 800, a virtual machine instance with 6GiB memory will timeout if it has not completed migration in 1h20m. Use a lower completionTimeoutPerGiB to induce quicker failure, so that another destination or post-copy is attempted. Use a higher completionTimeoutPerGiB to let workload with spikes in its memory dirty rate to converge. The format is a number. | *int64 | 800 | false |
+| completionTimeoutPerGiB | If a migrating VM is big and busy, while the connection to the destination node is slow, migration may never converge. The completion timeout is calculated based on completionTimeoutPerGiB times the size of the guest (both RAM and migrated disks, if any). For example, with completionTimeoutPerGiB set to 800, a virtual machine instance with 6GiB memory will timeout if it has not completed migration in 1h20m. Use a lower completionTimeoutPerGiB to induce quicker failure, so that another destination or post-copy is attempted. Use a higher completionTimeoutPerGiB to let workload with spikes in its memory dirty rate to converge. The format is a number. | *int64 | 150 | false |
 | progressTimeout | The migration will be canceled if memory copy fails to make progress in this time, in seconds. | *int64 | 150 | false |
 | network | The migrations will be performed over a dedicated multus network to minimize disruption to tenant workloads due to network saturation when VM live migrations are triggered. | *string |  | false |
 | allowAutoConverge | AllowAutoConverge allows the platform to compromise performance/availability of VMIs to guarantee successful VMI live migrations. Defaults to false | *bool | false | false |

tests/func-tests/defaults_test.go

@@ -106,7 +106,7 @@ var _ = Describe("Check Default values", Label("defaults"), Serial, func() {
 		defaultLiveMigrationConfig := v1beta1.LiveMigrationConfigurations{
 			AllowAutoConverge:                 ptr.To(false),
 			AllowPostCopy:                     ptr.To(false),
-			CompletionTimeoutPerGiB:           ptr.To(int64(800)),
+			CompletionTimeoutPerGiB:           ptr.To(int64(150)),
 			ParallelMigrationsPerCluster:      ptr.To(uint32(5)),
 			ParallelOutboundMigrationsPerNode: ptr.To(uint32(2)),
 			ProgressTimeout:                   ptr.To(int64(150)),