Skip to content

Commit

Permalink
e2e: Fix artifacts collecting
Browse files Browse the repository at this point in the history
Due to actions/upload-artifact#602
Hidden folders are skipped.
We are using .output, so it was skipped and artifacts were not collected in case of an error.
Rename it to fix the problem.

Signed-off-by: Or Shoval <[email protected]>
  • Loading branch information
oshoval committed Sep 8, 2024
1 parent bd56064 commit edd8960
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 2 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/checks.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -82,4 +82,4 @@ jobs:
if: failure()
with:
name: test-logs
path: ./test/e2e/.output/*.log
path: ./test/e2e/_output/*.log
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -29,3 +29,4 @@ go.work

# output dir for the hack/cluster.sh artifacts and e2e tests
.output
_output
2 changes: 1 addition & 1 deletion test/e2e/e2e_suite_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ import (
testenv "github.com/kubevirt/ipam-extensions/test/env"
)

const logsDir = ".output" // ./test/e2e/.output
const logsDir = "_output" // ./test/e2e/_output

var _ = BeforeSuite(func() {
ctrl.SetLogger(zap.New(zap.WriteTo(GinkgoWriter), zap.UseDevMode(true)))
Expand Down

0 comments on commit edd8960

Please sign in to comment.