Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kubevirtci: Bump kubevirtci #62

Closed
wants to merge 1 commit into from
Closed

Conversation

oshoval
Copy link
Collaborator

@oshoval oshoval commented Sep 18, 2023

What this PR does / why we need it:

Special notes for your reviewer:
Latest (2309141019-029e67a) kubevirtci doesn't work [1]
for now pinning newer than current meanwhile,

[1] https://prow.ci.kubevirt.io/view/gs/kubevirt-prow/pr-logs/pull/kubevirt_kubesecondarydns/62/pull-kubesecondarydns-e2e-k8s/1703684178278617088

@kubevirt-bot kubevirt-bot added the dco-signoff: yes Indicates the PR's author has DCO signed all their commits. label Sep 18, 2023
@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign alonakaplan for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@oshoval
Copy link
Collaborator Author

oshoval commented Sep 18, 2023

@kubevirt-bot kubevirt-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 18, 2023
@oshoval
Copy link
Collaborator Author

oshoval commented Sep 18, 2023

will reopen once back to it

@oshoval oshoval closed this Sep 18, 2023
@oshoval oshoval reopened this Sep 18, 2023
@oshoval oshoval changed the title kubevirtci: Bump and use k8s-1.28 kubevirtci: Bump and use k8s-1.27 Sep 18, 2023
@oshoval
Copy link
Collaborator Author

oshoval commented Sep 18, 2023

/hold cancel

@kubevirt-bot kubevirt-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 18, 2023
@oshoval
Copy link
Collaborator Author

oshoval commented Sep 18, 2023

/hold

hmm failed, (locally passed)
prow is laggy today, will look later on why it failed
(btw saw one time a flake also not on this PR, so maybe related)

@kubevirt-bot kubevirt-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 18, 2023
@oshoval oshoval changed the title kubevirtci: Bump and use k8s-1.27 kubevirtci: Bump kubevirtci Sep 18, 2023
@oshoval
Copy link
Collaborator Author

oshoval commented Sep 18, 2023

let see if 1.25 with 2306031446-398ee73 works on CI (worked locally)
previous run with 1.27 and 2306031446-398ee73 didn't work on CI

@oshoval
Copy link
Collaborator Author

oshoval commented Sep 18, 2023

interesting, it pass with 1.25 on CI as well (assuming not a flake)
lets try again

/test pull-kubesecondarydns-e2e-k8s

@oshoval
Copy link
Collaborator Author

oshoval commented Sep 18, 2023

worth first to check current hash on main with 1.27
as we see that 1.27 doesnt work on bump, while 1.25 is

@oshoval oshoval closed this Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dco-signoff: yes Indicates the PR's author has DCO signed all their commits. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants