Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add snyk file to exclude vendor folders #67

Merged
merged 1 commit into from
Nov 7, 2023

Conversation

oshoval
Copy link
Collaborator

@oshoval oshoval commented Nov 6, 2023

What this PR does / why we need it:
This file is used for snyk integration to config snyk scan.

Special notes for your reviewer:

this file is used for snyk integration to config snyk scan.

Signed-off-by: Or Shoval <[email protected]>
@kubevirt-bot kubevirt-bot added the dco-signoff: yes Indicates the PR's author has DCO signed all their commits. label Nov 6, 2023
@phoracek
Copy link
Member

phoracek commented Nov 6, 2023

@oshoval would we still get an alert if our dependencies contain CVEs?

@oshoval
Copy link
Collaborator Author

oshoval commented Nov 6, 2023

@oshoval would we still get an alert if our dependencies contain CVEs?

Yes, this is for excluding the vendor folder during Code analysis
Packages analyzing is done via go.mod, not via Code analysis on vendor folder

See please kubevirt/ssp-operator#706

@phoracek
Copy link
Member

phoracek commented Nov 6, 2023

Understood. Thanks!

@AlonaKaplan
Copy link
Member

/lgtm
/approve

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 7, 2023
@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AlonaKaplan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 7, 2023
@kubevirt-bot kubevirt-bot merged commit 69b2631 into kubevirt:main Nov 7, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants