-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CVE-2023-44487: Bump grpc for indirect usages #68
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
We still have potential indirect uses of affected google.golang.org/grpc. For example cloud.google.com/go v0.97.0 (and many more according Synk). Hence bump grpc to a fixed version. GHSA-qppj-fm5r-hxr3 Signed-off-by: Or Shoval <[email protected]>
Hi Ram |
lets close (because the "freeze" issue, it is not a good practice, and we should prioritize) |
What this PR does / why we need it:
We still have potential indirect uses (go.sum)
of affected
google.golang.org/grpc
according Snyk.For example
cloud.google.com/go v0.97.0
.Note that it is not actually linked, else
it would be on go.mod as well.
Moreover in this case grpc isn't even vendored.
Bump grpc to a fixed version (using replace directive).
This in turn also auto deprecate some old versions,
for example it replaced here
cloud.google.com/go v0.97.0
.It will make the scanner happy, and also avoid silent possible
use of the affected package in the future.
GHSA-qppj-fm5r-hxr3
Special notes for your reviewer: