add multiarch support for kubevirt tasks #698

Basavaraju-G · 2025-03-19T08:40:43Z

What this PR does / why we need it:
As of now Tekton kubevirt tasks supported only on x86/amd64. so this PR will add support for s390x, arm64 cpu platforms.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Release note:

NONE

kubevirt-bot · 2025-03-19T08:40:47Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign ksimon1 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci · 2025-03-19T08:40:50Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Basavaraju-G
Once this PR has been reviewed and has the lgtm label, please assign ksimon1 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci · 2025-03-19T08:40:55Z

Hi @Basavaraju-G. Thanks for your PR.

I'm waiting for a kubevirt member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Basavaraju-G · 2025-03-19T08:41:41Z

Hi @ksimon1 would you please review this PR?

0xFelix

Your commit looks to be mangled (author, message). Can you please correct that?

0xFelix · 2025-03-19T09:41:52Z

release/tasks/disk-virt-customize/disk-virt-customize.yaml

@@ -7,7 +7,7 @@ metadata:
    tekton.dev/categories: Automation
    tekton.dev/tags: kubevirt
    tekton.dev/displayName: "KubeVirt disk virt customize"
-    tekton.dev/platforms: "linux/amd64"
+    tekton.dev/platforms: "linux/amd64,linux/arm64"


We need quay.io/kubevirt/libguestfs-tools for s390x to add it here, correct?

Hi @0xFelix currently we dont have s390x image of quay.io/kubevirt/libguestfs-tools , and we are working on it to have s390x multiarch image. once the "quay.io/kubevirt/libguestfs-tools" have multi arch s390x image, i will add it in separate PR. is this okay?

0xFelix · 2025-03-19T09:42:48Z

scripts/build-release-images.sh

@@ -12,11 +12,19 @@ SCRIPT_DIR="$(dirname "$(readlink -f "$0")")"
 source "${SCRIPT_DIR}/release-var.sh"
 source "${SCRIPT_DIR}/common.sh"

+# add qemu-user-static
+sudo podman run --rm --privileged docker.io/multiarch/qemu-user-static --reset -p yes


What does that do? Also, we should try to not use images on Docker hub.

Hi @0xFelix Here we are trying to use qemu-user-emulation to build multiarch images on x86 native platform. i was taken this from here https://github.com/kubevirt/kubevirt/blob/add278ad94ca13c112b8da83f41160f7371501b5/hack/builder/build.sh#L19 to cross building on x86 platform.

Is the qemu-user-static image available on quay?

I don't see where this is registered as a runner for foreign binaries though? Does it happen in the container? Also, why not make it conditional like in the file you've linked?

Is the qemu-user-static image available on quay?

No its not there in quay.

I don't see where this is registered as a runner for foreign binaries though? Does it happen in the container? Also, why not make it conditional like in the file you've linked?

No, it wont happen in container. sure i will make a check before running it.

I don't see where this is registered as a runner for foreign binaries though? Does it happen in the container? Also, why not make it conditional like in the file you've linked?

Hi @0xFelix added condition to install if not enabled.

Basavaraju-G · 2025-03-19T14:08:24Z

Your commit looks to be mangled (author, message). Can you please correct that?

fixed

ksimon1 · 2025-03-20T07:11:35Z

@Basavaraju-G are you planning to add test runners for e2e tests on s390x?

Basavaraju-G · 2025-03-20T14:15:51Z

@Basavaraju-G are you planning to add test runners for e2e tests on s390x?

@ksimon1 yes we have it in planning. we have some kubevirt projects in https://prow.ci.kubevirt.io/ are running s390x e2e jobs in here https://prow.ci.kubevirt.io/view/gs/kubevirt-prow/logs/publish-kubevirtci-s390x/1902662300989394944.

ksimon1 · 2025-03-21T12:28:10Z

@Basavaraju-G I tried to trigger it locally and it is failing on:

[linux/s390x] [2/2] STEP 3/10: RUN dnf install -y xorriso openssh-clients nbdkit nbdkit-curl-plugin qemu-img && dnf clean all
container exited on segmentation fault
Error: 2 errors occurred:
	* [linux/arm64]: building at STEP "RUN dnf install -y xorriso openssh-clients nbdkit nbdkit-curl-plugin qemu-img && dnf clean all": while running runtime: exit status 1
	* [linux/s390x]: building at STEP "RUN dnf install -y xorriso openssh-clients nbdkit nbdkit-curl-plugin qemu-img && dnf clean all": while running runtime: exit status 1

Basavaraju-G · 2025-03-24T03:02:21Z

@Basavaraju-G I tried to trigger it locally and it is failing on:

[linux/s390x] [2/2] STEP 3/10: RUN dnf install -y xorriso openssh-clients nbdkit nbdkit-curl-plugin qemu-img && dnf clean all
container exited on segmentation fault
Error: 2 errors occurred:
	* [linux/arm64]: building at STEP "RUN dnf install -y xorriso openssh-clients nbdkit nbdkit-curl-plugin qemu-img && dnf clean all": while running runtime: exit status 1
	* [linux/s390x]: building at STEP "RUN dnf install -y xorriso openssh-clients nbdkit nbdkit-curl-plugin qemu-img && dnf clean all": while running runtime: exit status 1

HI @ksimon1 may i know what version of podman your using it? and may i know which OS are you building on it(RHEL/Ubuntu)? i was able to build with github actions job. build log here https://github.com/Basavaraju-G/kubevirt-tekton-tasks/actions/runs/13896150271/job/38877127084.

0xFelix

To me it looks okay from what I can tell

/ok-to-test

0xFelix · 2025-03-25T12:05:02Z

release/tasks/disk-virt-customize/disk-virt-customize.yaml

@@ -7,7 +7,7 @@ metadata:
    tekton.dev/categories: Automation
    tekton.dev/tags: kubevirt
    tekton.dev/displayName: "KubeVirt disk virt customize"
-    tekton.dev/platforms: "linux/amd64"
+    tekton.dev/platforms: "linux/amd64,linux/arm64"


Basavaraju-G · 2025-03-25T14:00:10Z

/retest

ksimon1 · 2025-03-26T07:26:17Z

release/tasks/cleanup-vm/cleanup-vm.yaml

@@ -7,7 +7,7 @@ metadata:
    tekton.dev/categories: Automation
    tekton.dev/tags: kubevirt
    tekton.dev/displayName: "KubeVirt cleanup VM"
-    tekton.dev/platforms: "linux/amd64"
+    tekton.dev/platforms: "linux/amd64,linux/s390x,linux/arm64"


these changes has to go to manifests in templates folder and then run make generate-yaml-tasks

kubevirt-bot requested a review from 0xFelix March 19, 2025 08:40

kubevirt-bot added the dco-signoff: yes Indicates the PR's author has DCO signed all their commits. label Mar 19, 2025

kubevirt-bot requested a review from lyarwood March 19, 2025 08:40

kubevirt-bot added the do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. label Mar 19, 2025

openshift-ci bot requested a review from ksimon1 March 19, 2025 08:40

kubevirt-bot added the size/M label Mar 19, 2025

openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Mar 19, 2025

kubevirt-bot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Mar 19, 2025

0xFelix reviewed Mar 19, 2025

View reviewed changes

Basavaraju-G force-pushed the multiarch-support branch from a4c89d2 to cc44132 Compare March 19, 2025 14:07

add multiarch support for kubevirt tasks

9e3f342

Basavaraju-G force-pushed the multiarch-support branch from cc44132 to 9e3f342 Compare March 25, 2025 04:12

0xFelix reviewed Mar 25, 2025

View reviewed changes

openshift-ci bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 25, 2025

ksimon1 reviewed Mar 26, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add multiarch support for kubevirt tasks #698

add multiarch support for kubevirt tasks #698

Basavaraju-G commented Mar 19, 2025 •

edited

Loading

kubevirt-bot commented Mar 19, 2025

openshift-ci bot commented Mar 19, 2025

openshift-ci bot commented Mar 19, 2025

Basavaraju-G commented Mar 19, 2025

0xFelix left a comment

0xFelix Mar 19, 2025

Basavaraju-G Mar 19, 2025 •

edited

Loading

0xFelix Mar 25, 2025

0xFelix Mar 19, 2025

Basavaraju-G Mar 19, 2025

ksimon1 Mar 19, 2025

0xFelix Mar 20, 2025

Basavaraju-G Mar 20, 2025

Basavaraju-G Mar 20, 2025

Basavaraju-G Mar 25, 2025

Basavaraju-G commented Mar 19, 2025

ksimon1 commented Mar 20, 2025

Basavaraju-G commented Mar 20, 2025 •

edited

Loading

ksimon1 commented Mar 21, 2025

Basavaraju-G commented Mar 24, 2025 •

edited

Loading

0xFelix left a comment

0xFelix Mar 25, 2025

Basavaraju-G commented Mar 25, 2025

ksimon1 Mar 26, 2025

add multiarch support for kubevirt tasks #698

Are you sure you want to change the base?

add multiarch support for kubevirt tasks #698

Conversation

Basavaraju-G commented Mar 19, 2025 • edited Loading

kubevirt-bot commented Mar 19, 2025

openshift-ci bot commented Mar 19, 2025

openshift-ci bot commented Mar 19, 2025

Basavaraju-G commented Mar 19, 2025

0xFelix left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Basavaraju-G Mar 19, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Basavaraju-G commented Mar 19, 2025

ksimon1 commented Mar 20, 2025

Basavaraju-G commented Mar 20, 2025 • edited Loading

ksimon1 commented Mar 21, 2025

Basavaraju-G commented Mar 24, 2025 • edited Loading

0xFelix left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Basavaraju-G commented Mar 25, 2025

Choose a reason for hiding this comment

Basavaraju-G commented Mar 19, 2025 •

edited

Loading

Basavaraju-G Mar 19, 2025 •

edited

Loading

Basavaraju-G commented Mar 20, 2025 •

edited

Loading

Basavaraju-G commented Mar 24, 2025 •

edited

Loading